Fix FileNotFoundErrors to support windows #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mataton Good job! You can directly create a PR to the biocore repo. You can just copy my code in the other PR, and add yours. |
qiyunzhu
reviewed
Apr 5, 2024
| os.chdir(__file__.rsplit('/', 1)[0]) | ||
| obs = _subset_table(hdf5_biom='test_data/test.biom', axis='sample', | ||
| if os.path.sep in __file__: | ||
| os.chdir(__file__.rsplit(os.path.sep, 1)[0]) |
There was a problem hiding this comment.
__file__.rsplit(os.path.sep, 1)[0] can be os.path.dirname(__file__), I guess.
* added numpy-2.0 support * Update ChangeLog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qiyunzhu Is this the preferred method for adding code to someone else's existing PR? With the current PR #949 you have on BIOM's main branch, I believe if you accept these changes into your
windowsbranch that they will be reflected in that PR (biocore#949). If there is a better way to do this please let me know.These changes fix all
FileNotFoundErrors which were present. All that was needed was to change the file separators from hard coded'/'which doesn't work with windows, toos.path.sep, and to useos.path.joinon the file paths.