Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new keys for Copy settings (uYouPlusSettings.xm) #1563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aricloverALT
Copy link

@aricloverALT aricloverALT commented Sep 7, 2024

Hello theRealFoxster! I checked that the Copy settings button wasn’t good enough that was added in my last pull request but this Pull Request will update “Copy settings” to include support for more options such as DontEatMyContent, Return YouTube Dislikes, YouMute, YouQuality & YouPiP.

This pull request originally also included the keys from the tweaks YouTimeStamp and YouLoop but got rid of them since uYouPlus doesn’t have those.

Credit:
bhackel - for helping me find the keys for the other tweaks. Wouldn’t have been easy to find the keys without them!

@cameren2k
Copy link

Maybe a separate pull request to include YouLoop and YouTimeStamp. I can see the value in including these tweaks, unless people are not interested

@aricloverALT
Copy link
Author

aricloverALT commented Sep 8, 2024

Maybe a separate pull request to include YouLoop and YouTimeStamp. I can see the value in including these tweaks, unless people are not interested

Well, they are useful tweaks that were made for the ‘YTVideoOverlay’ tweak that adds new buttons in the video player. bhackel’s ‘YouLoop’ tweak adds in a “Loop” button allowing you to loop videos after they end, and my ‘YouTimeStamp’ tweak allows you to copy the YouTube video URL with the ‘?t=timestamp_number’ parameter using a button. I’m not sure if the developers would want to include them, but I’ll ask them about it.

@"DEMC_enabled", @"DEMC_colorViewsEnabled", @"DEMC_safeAreaConstant", @"DEMC_disableAmbientMode",
@"DEMC_limitZoomToFill", @"DEMC_enableForAllVideos",
// Return YouTube Dislikes Keys - https://github.com/PoomSmart/Return-YouTube-Dislikes/blob/main/TweakSettings.h
@"RYD-ENABLED", @"RYD-VOTE-SUBMISSION", @"RYD-EXACT-LIKE-NUMBER", @"RYD-EXACT-NUMBER",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the url for this line was supposed to be https://github.com/PoomSmart/YTVideoOverlay/blob/main/Tweak.x
I’ll fix that whenever I get permission to add in the YouTimeStamp & YouLoop keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants