Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve DX with docker #70

Merged
merged 1 commit into from
Oct 6, 2024
Merged

chore: Improve DX with docker #70

merged 1 commit into from
Oct 6, 2024

Conversation

ndench
Copy link
Contributor

@ndench ndench commented Aug 11, 2024

While working on #69, there were a few small changes I needed to make to successfully run all the required CI tools under the provided docker image.

  1. Infection hits the memory limit
  2. The build requires the git repository to be marked as safe
  3. Setting "bash" as the CMD saves a few keystrokes when getting into the docker container

I've also added some docs to CONTRIBUTING.md explaining how to use the container.

@gennadigennadigennadi gennadigennadigennadi merged commit 3cc0500 into qossmic:2.0.x Oct 6, 2024
19 checks passed
@ndench ndench deleted the chore/improve-docker-dx branch October 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickkusebauch patrickkusebauch patrickkusebauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndench @patrickkusebauch @gennadigennadigennadi