Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4951][IMP] inventory_reporting #106

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

kanda999
Copy link
Contributor

@kanda999 kanda999 commented Jan 9, 2025

@kanda999 kanda999 force-pushed the 4951-imp-inventory_reporting branch from b9a84e8 to 3816568 Compare January 9, 2025 03:12
Comment on lines +130 to +134
(
"stock_move_id.location_id.is_subcontracting_location",
"=",
False,
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be like this:

Suggested change
(
"stock_move_id.location_id.is_subcontracting_location",
"=",
False,
),
"|",
"&",
("stock_move_id.location_dest_id.usage", "=", "production"),
(
"stock_move_id.location_id.is_subcontracting_location",
"=",
False,
),
"&",
("stock_move_id.location_id.usage", "=", "production"),
(
"stock_move_id.location_dest_id.is_subcontracting_location",
"=",
False,
),
("stock_move_id.picking_code", "in", ("internal", "outgoing")),
("stock_move_id.unbuild_id", "=", False),
("stock_move_id.origin_returned_move_id", "=", False),

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (no functional test).

Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Code Review.

@nobuQuartile
Copy link

LGTM: Test the module at copy-env.
The lines that were double-displayed were only displayed on the subcontract processing sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants