Only let people join at start of loop

QSB/Anglerfish/WorldObjects/QSBAngler.cs

@@ -18,9 +18,6 @@ public class QSBAngler : LinkedWorldObject<AnglerfishController, AnglerTransform
 	protected override GameObject NetworkObjectPrefab => QSBNetworkManager.singleton.AnglerPrefab;
 	protected override bool SpawnWithServerOwnership => false;
 
-	public override void SendInitialState(uint to) =>
-		this.SendMessage(new AnglerDataMessage(this) { To = to });
-
 	public void UpdateTargetVelocity()
 	{
 		if (TargetTransform == null)

QSB/Animation/Player/AnimationSync.cs

@@ -6,7 +6,6 @@
 using QSB.Messaging;
 using QSB.Player;
 using QSB.Utility;
-using QSB.WorldSync;
 using System;
 using UnityEngine;
 
@@ -31,18 +30,8 @@ protected void Awake()
 		InvisibleAnimator = gameObject.GetRequiredComponent<Animator>();
 		NetworkAnimator = gameObject.GetRequiredComponent<NetworkAnimator>();
 		NetworkAnimator.enabled = false;
-		RequestInitialStatesMessage.SendInitialState += SendInitialState;
 	}
 
-	protected void OnDestroy() => RequestInitialStatesMessage.SendInitialState -= SendInitialState;
-
-	/// <summary>
-	/// This wipes the NetworkAnimator's fields, so it assumes the parameters have changed.
-	/// Basically just forces it to set all its dirty flags.
-	/// BUG: this doesnt work for other players because its only called by the host.
-	/// </summary>
-	private void SendInitialState(uint to) => NetworkAnimator.Invoke("Awake");
-
 	public void Reset() => InSuitedUpState = false;
 
 	private void InitCommon(Transform modelRoot)

QSB/CampfireSync/Messages/BurnSlideReelMessage.cs

@@ -6,9 +6,6 @@
 
 namespace QSB.CampfireSync.Messages;
 
-/// <summary>
-/// TODO: initial state on campfire and item
-/// </summary>
 public class BurnSlideReelMessage : QSBWorldObjectMessage<QSBSlideReelItem, int>
 {
 	public BurnSlideReelMessage(QSBCampfire campfire) : base(campfire.ObjectId) { }

QSB/CampfireSync/WorldObjects/QSBCampfire.cs

@@ -6,9 +6,6 @@ namespace QSB.CampfireSync.WorldObjects;
 
 public class QSBCampfire : WorldObject<Campfire>
 {
-	public override void SendInitialState(uint to) =>
-		this.SendMessage(new CampfireStateMessage(GetState()) { To = to });
-
 	public void StartRoasting()
 		=> AttachedObject.StartRoasting();
 

QSB/ConversationSync/WorldObjects/QSBCharacterDialogueTree.cs

@@ -21,16 +21,6 @@ public override void OnRemoval()
 		QSBPlayerManager.OnRemovePlayer -= OnRemovePlayer;
 	}
 
-	public override void SendInitialState(uint to)
-	{
-		var playerId = ConversationManager.Instance.GetPlayerTalkingToTree(AttachedObject);
-		if (playerId != uint.MaxValue)
-		{
-			this.SendMessage(new ConversationStartEndMessage(playerId, true) { To = to });
-		}
-		// TODO: maybe also sync the dialogue box and player box?
-	}
-
 	private void OnRemovePlayer(PlayerInfo player)
 	{
 		if (player.CurrentCharacterDialogueTree == this)

QSB/ConversationSync/WorldObjects/QSBRemoteDialogueTrigger.cs

@@ -1,14 +1,9 @@
-using QSB.ConversationSync.Messages;
-using QSB.Messaging;
-using QSB.WorldSync;
+using QSB.WorldSync;
 
 namespace QSB.ConversationSync.WorldObjects;
 
 public class QSBRemoteDialogueTrigger : WorldObject<RemoteDialogueTrigger>
 {
-	public override void SendInitialState(uint to) =>
-		this.SendMessage(new RemoteDialogueInitialStateMessage(AttachedObject) { To = to });
-
 	public void RemoteEnterDialogue(int dialogueIndex)
 	{
 		var dialogueCondition = AttachedObject._listDialogues[dialogueIndex];

QSB/EchoesOfTheEye/AirlockSync/WorldObjects/QSBGhostAirlock.cs

@@ -1,17 +1,5 @@
-using QSB.EchoesOfTheEye.AirlockSync.Messages;
-using QSB.Messaging;
-using QSB.WorldSync;
+using QSB.WorldSync;
 
 namespace QSB.EchoesOfTheEye.AirlockSync.WorldObjects;
 
-public class QSBGhostAirlock : WorldObject<GhostAirlock>
-{
-	public override void SendInitialState(uint to)
-		=> this.SendMessage(
-			new AirlockInitialStateMessage(
-				AttachedObject._innerDoor.IsOpen(),
-				AttachedObject._outerDoor.IsOpen(),
-				AttachedObject._pressurized
-			)
-		);
-}
+public class QSBGhostAirlock : WorldObject<GhostAirlock> { }

QSB/EchoesOfTheEye/AlarmTotemSync/WorldObjects/QSBAlarmTotem.cs

@@ -1,17 +1,8 @@
-using QSB.EchoesOfTheEye.AlarmTotemSync.Messages;
-using QSB.Messaging;
-using QSB.OwnershipSync;
+using QSB.OwnershipSync;
 
 namespace QSB.EchoesOfTheEye.AlarmTotemSync.WorldObjects;
 
 public class QSBAlarmTotem : OwnedWorldObject<AlarmTotem>
 {
 	public override bool CanOwn => AttachedObject.enabled;
-
-	public override void SendInitialState(uint to)
-	{
-		base.SendInitialState(to);
-
-		this.SendMessage(new SetVisibleMessage(AttachedObject._isPlayerVisible) { To = to });
-	}
 }

QSB/EchoesOfTheEye/DreamCandles/WorldObjects/QSBDreamCandle.cs

@@ -1,11 +1,5 @@
-using QSB.EchoesOfTheEye.DreamCandles.Messages;
-using QSB.Messaging;
-using QSB.WorldSync;
+using QSB.WorldSync;
 
 namespace QSB.EchoesOfTheEye.DreamCandles.WorldObjects;
 
-public class QSBDreamCandle : WorldObject<DreamCandle>
-{
-	public override void SendInitialState(uint to) =>
-		this.SendMessage(new SetLitMessage(AttachedObject._lit, false, true) { To = to });
-}
+public class QSBDreamCandle : WorldObject<DreamCandle> { }

QSB/EchoesOfTheEye/DreamLantern/WorldObjects/QSBDreamLanternController.cs

@@ -1,6 +1,4 @@
 using Cysharp.Threading.Tasks;
-using QSB.EchoesOfTheEye.DreamLantern.Messages;
-using QSB.Messaging;
 using QSB.WorldSync;
 using System.Threading;
 
@@ -19,13 +17,5 @@ public override async UniTask Init(CancellationToken ct)
 		}
 	}
 
-	public override void SendInitialState(uint to)
-	{
-		this.SendMessage(new SetLitMessage(AttachedObject._lit) { To = to });
-		this.SendMessage(new SetConcealedMessage(AttachedObject._concealed) { To = to });
-		this.SendMessage(new SetFocusMessage(AttachedObject._focus) { To = to });
-		this.SendMessage(new SetRangeMessage(AttachedObject._minRange, AttachedObject._maxRange) { To = to });
-	}
-
 	public bool IsGhostLantern => AttachedObject.name == "GhostLantern"; // it's as shrimple as that
 }

QSB/EchoesOfTheEye/DreamObjectProjectors/WorldObject/QSBDreamObjectProjector.cs

@@ -1,11 +1,5 @@
-using QSB.EchoesOfTheEye.DreamObjectProjectors.Messages;
-using QSB.Messaging;
-using QSB.WorldSync;
+using QSB.WorldSync;
 
 namespace QSB.EchoesOfTheEye.DreamObjectProjectors.WorldObject;
 
-public class QSBDreamObjectProjector : WorldObject<DreamObjectProjector>
-{
-	public override void SendInitialState(uint to)
-		=> this.SendMessage(new ProjectorLitMessage(AttachedObject._lit) { To = to });
-}
+public class QSBDreamObjectProjector : WorldObject<DreamObjectProjector> { }

QSB/EchoesOfTheEye/DreamWorld/Messages/EnterDreamWorldMessage.cs

@@ -8,9 +8,6 @@
 
 namespace QSB.EchoesOfTheEye.DreamWorld.Messages;
 
-/// <summary>
-/// todo SendInitialState
-/// </summary>
 public class EnterDreamWorldMessage : QSBWorldObjectMessage<QSBDreamLanternItem>
 {
 	static EnterDreamWorldMessage()

QSB/EchoesOfTheEye/DreamWorld/Messages/ExitDreamWorldMessage.cs

@@ -6,9 +6,6 @@
 
 namespace QSB.EchoesOfTheEye.DreamWorld.Messages;
 
-/// <summary>
-/// todo SendInitialState
-/// </summary>
 public class ExitDreamWorldMessage : QSBMessage
 {
 	static ExitDreamWorldMessage()

QSB/EchoesOfTheEye/EclipseCodeControllers/WorldObjects/QSBEclipseCodeController.cs

@@ -11,12 +11,6 @@ public class QSBEclipseCodeController : WorldObject<EclipseCodeController4>
 {
 	public PlayerInfo PlayerInControl;
 
-	public override void SendInitialState(uint to)
-	{
-		this.SendMessage(new InitialStateMessage(AttachedObject) { To = to });
-		this.SendMessage(new UseControllerMessage(PlayerInControl?.PlayerId ?? 0) { To = to });
-	}
-
 	public override async UniTask Init(CancellationToken ct)
 	{
 		QSBPlayerManager.OnRemovePlayer += OnPlayerLeave;

QSB/EchoesOfTheEye/EclipseElevators/WorldObjects/QSBElevatorDestination.cs

@@ -2,10 +2,4 @@
 
 namespace QSB.EchoesOfTheEye.EclipseElevators.WorldObjects;
 
-public class QSBElevatorDestination : WorldObject<ElevatorDestination>
-{
-	public override void SendInitialState(uint to)
-	{
-		// todo : implement
-	}
-}
+public class QSBElevatorDestination : WorldObject<ElevatorDestination> { }

QSB/EchoesOfTheEye/Ghosts/WorldObjects/QSBGhostBrain.cs

@@ -19,11 +19,6 @@ public class QSBGhostBrain : WorldObject<GhostBrain>, IGhostObject
 {
 	#region World Object Stuff
 
-	public override void SendInitialState(uint to)
-	{
-		// todo SendInitialState
-	}
-
 	public override async UniTask Init(CancellationToken ct)
 	{
 		Awake();

QSB/EchoesOfTheEye/Ghosts/WorldObjects/QSBGhostController.cs

@@ -15,11 +15,6 @@ namespace QSB.EchoesOfTheEye.Ghosts.WorldObjects;
 
 public class QSBGhostController : WorldObject<GhostController>, IGhostObject
 {
-	public override void SendInitialState(uint to)
-	{
-		// todo SendInitialState
-	}
-
 	public QSBGhostEffects _effects;
 
 	public void Initialize(GhostNode.NodeLayer layer, QSBGhostEffects effects)

QSB/EchoesOfTheEye/Ghosts/WorldObjects/QSBGhostEffects.cs

@@ -14,11 +14,6 @@ namespace QSB.EchoesOfTheEye.Ghosts.WorldObjects;
 
 public class QSBGhostEffects : WorldObject<GhostEffects>, IGhostObject
 {
-	public override void SendInitialState(uint to)
-	{
-		// todo SendInitialState
-	}
-
 	public override bool ShouldDisplayDebug() => false;
 
 	private QSBGhostData _data;

QSB/EchoesOfTheEye/Ghosts/WorldObjects/QSBGhostGrabController.cs

@@ -9,11 +9,6 @@ namespace QSB.EchoesOfTheEye.Ghosts.WorldObjects;
 
 public class QSBGhostGrabController : WorldObject<GhostGrabController>
 {
-	public override void SendInitialState(uint to)
-	{
-		// todo SendInitialState
-	}
-
 	public void GrabPlayer(float speed, GhostPlayer player, bool remote = false)
 	{
 		if (!remote)