Skip to content

Commit

Permalink
Merge pull request #1851 from quadratichq/ayush/doubleClickTimeout
Browse files Browse the repository at this point in the history
fix: edit cell bug after pointer move
  • Loading branch information
davidkircos authored Sep 11, 2024
2 parents 0fbb384 + 09dcd4d commit e0380c5
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { events } from '@/app/events/events';
import { inlineEditorHandler } from '@/app/gridGL/HTMLGrid/inlineEditor/inlineEditorHandler';
import { quadraticCore } from '@/app/web-workers/quadraticCore/quadraticCore';
import { Point, Rectangle } from 'pixi.js';
import { isMobile } from 'react-device-detect';
import { sheets } from '../../../grid/controller/Sheets';
import { inlineEditorMonaco } from '../../HTMLGrid/inlineEditor/inlineEditorMonaco';
import { pixiApp } from '../../pixiApp/PixiApp';
import { PanMode, pixiAppSettings } from '../../pixiApp/PixiAppSettings';
import { doubleClickCell } from './doubleClickCell';
import { DOUBLE_CLICK_TIME } from './pointerUtils';
import { events } from '@/app/events/events';
import { inlineEditorMonaco } from '../../HTMLGrid/inlineEditor/inlineEditorMonaco';

const MINIMUM_MOVE_POSITION = 5;

Expand Down Expand Up @@ -191,8 +191,7 @@ export class PointerDown {
const sheet = sheets.sheet;
const cursor = sheet.cursor;

// for determining if double click
if (!this.pointerMoved && this.doubleClickTimeout && this.positionRaw) {
if (!this.pointerMoved && this.positionRaw) {
if (
Math.abs(this.positionRaw.x - world.x) + Math.abs(this.positionRaw.y - world.y) >
MINIMUM_MOVE_POSITION / viewport.scale.x
Expand Down

0 comments on commit e0380c5

Please sign in to comment.