Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Sept 5 #1848

Merged
merged 195 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
195 commits
Select commit Hold shift + click to select a range
0833abe
make viewport+neighbour rect available to core during transaction
AyushAgrawal-A2 Aug 7, 2024
280cf58
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Aug 7, 2024
ce14bae
fix test
AyushAgrawal-A2 Aug 7, 2024
630489c
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Aug 11, 2024
dcdab31
set values complete
AyushAgrawal-A2 Aug 11, 2024
2ba8e9d
set formats complete
AyushAgrawal-A2 Aug 11, 2024
ae3f2bc
add update
AyushAgrawal-A2 Aug 11, 2024
9a6c648
add Date, Time, and DateTime to types
davidfig Aug 13, 2024
9f9cf72
parsing date, time, and date times
davidfig Aug 13, 2024
b4c3aea
WIP datetime format menu
davidfig Aug 13, 2024
d3ac22a
getting clsoer
davidfig Aug 13, 2024
4f97687
fixed rendering with date_time format
davidfig Aug 14, 2024
02ea963
working through dialog changes
davidfig Aug 14, 2024
5637c59
WIP date format menu is not working properly
davidfig Aug 14, 2024
11865d3
Merge branch 'data-validation' into datetime
davidfig Aug 14, 2024
9fa5b9a
import/export of format.date_time works properly
davidfig Aug 14, 2024
5cc6285
Merge branch 'data-validation' into datetime
davidfig Aug 14, 2024
a53f042
date time is set/checked properly from menu
davidfig Aug 14, 2024
1d80ac3
fixed bug with format not updating when opening submenu
davidfig Aug 14, 2024
2342494
more places for the UI element
davidfig Aug 15, 2024
862c43e
more places for the date/time format menu to open
davidfig Aug 15, 2024
6b966d2
fixed bug with time rendering
davidfig Aug 15, 2024
a519e3b
js import/export of Date and DateTime
davidfig Aug 15, 2024
6f7a25d
added from_js conversion for time
davidfig Aug 15, 2024
ea62d7a
fixed python to handle date and times
davidfig Aug 15, 2024
4560fde
fix python tests
davidfig Aug 15, 2024
7010578
to/from python
davidfig Aug 15, 2024
868fceb
WIP import arrow
davidfig Aug 15, 2024
fe2a292
parquet datetime plus tests
davidfig Aug 16, 2024
174611d
excel and csv tests for import
davidfig Aug 16, 2024
379585f
shared parsing of date times
davidfig Aug 16, 2024
cc32e83
fix python and js output of date
davidfig Aug 17, 2024
501de57
tests and clippy
davidfig Aug 17, 2024
e264e1b
fixed tests
davidfig Aug 17, 2024
d4406d1
finish up calendar interface w/keyboard
davidfig Aug 17, 2024
e2d2362
current date and time button
davidfig Aug 17, 2024
b09f597
WIP validation for date time
davidfig Aug 17, 2024
80b8d14
validation_date_time in rust
davidfig Aug 17, 2024
2e8f524
more test coverage for rust validation_date_time
davidfig Aug 18, 2024
7353320
import/export validation_date_time
davidfig Aug 18, 2024
a4622ae
added validation pane to state variable
davidfig Aug 18, 2024
995b8e2
started work on validation UI
davidfig Aug 18, 2024
bd3a362
WIP Date Time validation UI
davidfig Aug 18, 2024
0b9b227
continued work on dt validation
davidfig Aug 19, 2024
32464fe
removing unecessary deps
davidfig Aug 20, 2024
ee9b292
finish up date time part of validation UI
davidfig Aug 21, 2024
436c03d
working through time UI; fixed bug where blank validations were not s…
davidfig Aug 21, 2024
c000e02
console.logs
davidfig Aug 21, 2024
8756761
fix bugs in ranges; add validation message for date time
davidfig Aug 22, 2024
1a05f94
much better ValidationDateInput
davidfig Aug 22, 2024
e49205c
improved validation message text
davidfig Aug 22, 2024
44562db
fix extra 0 in front of time
davidfig Aug 22, 2024
53eb62b
fix test
davidfig Aug 22, 2024
c92ac69
prettier
davidfig Aug 22, 2024
a2116c1
Merge remote-tracking branch 'origin/qa' into datetime
davidfig Aug 22, 2024
dae4b9d
fix tests after merge with qa
davidfig Aug 22, 2024
de680e4
fix bug with time entry in calendar for grid
davidfig Aug 22, 2024
c940db1
add documentation
davidfig Aug 22, 2024
4adc67c
Merge branch 'qa' into datetime
davidfig Aug 22, 2024
406c1ff
Merge branch 'qa' into datetime
davidfig Aug 23, 2024
de71000
initial work
davidfig Aug 23, 2024
6c59384
Merge branch 'datetime' into datetime-autocomplete
davidfig Aug 23, 2024
3c95625
fix issues with pulling one date/time negatively
davidfig Aug 24, 2024
3787e85
clippy
davidfig Aug 24, 2024
e615fdb
Create bump.sh to bump all js and rust versions at once
ddimaria Aug 27, 2024
f9aab7d
add more date-only formats
davidfig Aug 27, 2024
4e15110
Add documentation to the bump.sh file
ddimaria Aug 28, 2024
54642a6
Rename init to skip, remove git commits and tagging
ddimaria Aug 28, 2024
0f655d9
bump
davidkircos Aug 28, 2024
082188f
don't auto add
davidkircos Aug 28, 2024
3f32bf9
add ci
davidkircos Aug 28, 2024
e93545e
add manual trigger
davidkircos Aug 28, 2024
216e7fc
on push
davidkircos Aug 28, 2024
9e1f0c1
remove push
davidkircos Aug 28, 2024
08944b2
update bump script to be compatible with linux
davidkircos Aug 28, 2024
e4c557e
trigger
davidkircos Aug 28, 2024
7376f10
prevent loop
davidkircos Aug 28, 2024
7627888
test
davidkircos Aug 28, 2024
bf5c728
fix
davidkircos Aug 28, 2024
498e9df
fix
davidkircos Aug 28, 2024
bfcbeaa
fix
davidkircos Aug 28, 2024
f3073e6
Bump version
github-actions[bot] Aug 28, 2024
0949ad6
initial commit
jimniels Aug 29, 2024
5821a31
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Aug 31, 2024
07e1568
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 1, 2024
dc6b691
impl send for viewportbuffer
AyushAgrawal-A2 Sep 2, 2024
5e24df8
render worker optimisations
AyushAgrawal-A2 Sep 2, 2024
97121e7
fix: tests
AyushAgrawal-A2 Sep 2, 2024
a6e3a2f
add tests
AyushAgrawal-A2 Sep 2, 2024
037a3cd
fix test
AyushAgrawal-A2 Sep 2, 2024
403c425
Merge remote-tracking branch 'origin/qa' into datetime
davidfig Sep 2, 2024
5daf0f4
fix clippy
davidfig Sep 2, 2024
969fee1
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 2, 2024
a4f0910
mock viewport for tests
AyushAgrawal-A2 Sep 2, 2024
2e83aa1
clippy
AyushAgrawal-A2 Sep 2, 2024
125aec7
private getRenderCells
AyushAgrawal-A2 Sep 2, 2024
c8f5f54
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Sep 3, 2024
6baa4b2
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Sep 3, 2024
b41cf2e
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/view…
AyushAgrawal-A2 Sep 4, 2024
9009b2f
increase neighbour rect
AyushAgrawal-A2 Sep 4, 2024
b2cd521
Merge pull request #1847 from quadratichq/main
davidkircos Sep 5, 2024
a00d812
fix: clear doubleClickTimeout on pointer move
AyushAgrawal-A2 Sep 6, 2024
15afeea
fix: handle empty avatar picture url
AyushAgrawal-A2 Sep 6, 2024
4f1217f
add try catch
AyushAgrawal-A2 Sep 6, 2024
dfbadc7
Merge pull request #1852 from quadratichq/ayush/avatar_bug
davidkircos Sep 6, 2024
737a511
use refactor from 1850
AyushAgrawal-A2 Sep 7, 2024
fc3a6ea
add claude to ai assistant in code editor
AyushAgrawal-A2 Sep 7, 2024
485cb4e
improve cell context in prompt
AyushAgrawal-A2 Sep 7, 2024
73790fa
fix bottom avatar margin
AyushAgrawal-A2 Sep 7, 2024
ad09412
reassert instructions
AyushAgrawal-A2 Sep 7, 2024
4c50e1a
try strong worded instructions
AyushAgrawal-A2 Sep 7, 2024
5c52e9c
typo
AyushAgrawal-A2 Sep 7, 2024
19c06b6
fix: bug
AyushAgrawal-A2 Sep 8, 2024
09dcd4d
Merge branch 'qa' into ayush/doubleClickTimeout
AyushAgrawal-A2 Sep 8, 2024
dd2f56c
shadcn dropdown
AyushAgrawal-A2 Sep 8, 2024
5883d16
fix kebab case bug in svg
AyushAgrawal-A2 Sep 8, 2024
86dc1d6
Merge branch 'qa' into datetime
davidfig Sep 9, 2024
f0d938c
fix text case
davidfig Sep 9, 2024
1220957
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 9, 2024
09db741
add ok button
davidfig Sep 9, 2024
26b6a0d
Merge branch 'datetime' into datetime-jim
davidfig Sep 9, 2024
0d516b3
fix bug with checkbox + list not properly switching
davidfig Sep 9, 2024
5a783f4
remove title from date format dialog
davidfig Sep 9, 2024
68734fe
add github bot to .clabot
davidkircos Sep 9, 2024
3785785
Merge branch 'repo-versioning' of https://github.com/quadratichq/quad…
davidkircos Sep 9, 2024
6c9ef69
update ci to final
davidkircos Sep 9, 2024
7fd0b14
remove package.json versions from rust dirs
davidkircos Sep 9, 2024
c826eea
add a verify command to bump.sh and check this in CI
davidkircos Sep 9, 2024
af2dbbd
Merge branch 'qa' into repo-versioning
davidkircos Sep 9, 2024
cdd0374
faster checkout for verify
davidkircos Sep 9, 2024
1cfaf11
Merge branch 'repo-versioning' of https://github.com/quadratichq/quad…
davidkircos Sep 9, 2024
d38f334
fix: download file breaks ability to interact with the sheet
AyushAgrawal-A2 Sep 10, 2024
2764070
update ui
AyushAgrawal-A2 Sep 10, 2024
4c13f8e
fix: bug
AyushAgrawal-A2 Sep 10, 2024
bd4ee2f
improve custom formatting
davidfig Sep 10, 2024
c1cd174
fix bg color for dateformat.tsx
davidfig Sep 10, 2024
5599155
new line shortcut
AyushAgrawal-A2 Sep 10, 2024
2e92da3
PR fies
davidfig Sep 10, 2024
02dc5bf
Merge branch 'datetime' into datetime-jim
davidfig Sep 10, 2024
359c9b2
update lockfile
davidkircos Sep 10, 2024
56e927e
fix formatting for dialog
davidfig Sep 10, 2024
c7831f3
resolve PR comments
davidfig Sep 10, 2024
3535f35
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 10, 2024
09161d8
Merge branch 'datetime' into datetime-jim
davidfig Sep 10, 2024
e28df05
jim feedback
AyushAgrawal-A2 Sep 10, 2024
8bc2ddb
textarea border radius and height change
AyushAgrawal-A2 Sep 10, 2024
51d013e
Use quadratichq/ts-rs instead of HactarCE/ts-rs
HactarCE Sep 10, 2024
4f61436
Use upstream ts-rs
HactarCE Sep 10, 2024
844f492
switch order of buttons; remove x to close in dateformat.tsx
davidfig Sep 10, 2024
c773b1d
Merge pull request #1821 from quadratichq/datetime-jim
davidfig Sep 10, 2024
2b0a043
fix date formatting
davidfig Sep 10, 2024
88d1cd4
update text area
AyushAgrawal-A2 Sep 10, 2024
0fbb384
Merge pull request #1805 from quadratichq/repo-versioning
davidkircos Sep 10, 2024
aa78036
Bump express from 4.19.2 to 4.20.0
dependabot[bot] Sep 10, 2024
0877172
Merge branch 'qa' into datetime
davidfig Sep 11, 2024
9183a12
add default date to show on top
davidfig Sep 11, 2024
289f906
shift AI Assistant tab
AyushAgrawal-A2 Sep 11, 2024
32c37c1
fix date_time formatting fns and add more tests
davidfig Sep 11, 2024
455aadb
fix clippy warnings
davidfig Sep 11, 2024
e1e9cdc
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 11, 2024
5ae2c8c
hide shortcuts using container query
AyushAgrawal-A2 Sep 11, 2024
f4c477c
move to shadcn components
jimniels Sep 11, 2024
59d0138
Merge branch 'ayush/claude' of github.com:quadratichq/quadratic into …
jimniels Sep 11, 2024
470fd14
align margins/padding
jimniels Sep 11, 2024
ebfdbf4
remove bottom padding to bring it closer
jimniels Sep 11, 2024
9c01157
fix textarea resize
AyushAgrawal-A2 Sep 11, 2024
e0380c5
Merge pull request #1851 from quadratichq/ayush/doubleClickTimeout
davidkircos Sep 11, 2024
2f67e07
Merge pull request #1858 from quadratichq/ayush/1857
davidkircos Sep 11, 2024
3b322e1
Merge pull request #1856 from quadratichq/data-validation-play-nicely
davidkircos Sep 11, 2024
e60e63f
Merge pull request #1860 from quadratichq/dependabot/npm_and_yarn/exp…
davidkircos Sep 11, 2024
9618d63
Merge pull request #1859 from quadratichq/quadratic-ts-rs
davidkircos Sep 11, 2024
aabf131
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/claude
AyushAgrawal-A2 Sep 11, 2024
514b000
fix lock file
AyushAgrawal-A2 Sep 11, 2024
3f9f00a
Revert "Use upstream ts-rs"
HactarCE Sep 12, 2024
2d04e8b
Merge pull request #1862 from quadratichq/quadratic-ts-rs
davidkircos Sep 12, 2024
a9faf6e
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/claude
AyushAgrawal-A2 Sep 12, 2024
88fd1cf
Merge pull request #1659 from quadratichq/ayush/viewport_core
davidkircos Sep 12, 2024
2029614
Merge pull request #1855 from quadratichq/ayush/claude
davidkircos Sep 12, 2024
00fc00c
fix: rendering bugs due to viewport_core pr
AyushAgrawal-A2 Sep 13, 2024
dc3b7e5
requested changes
davidfig Sep 13, 2024
778e9aa
Merge remote-tracking branch 'origin/qa' into datetime
davidfig Sep 13, 2024
23ce9c4
Merge branch 'datetime' into datetime-autocomplete
davidfig Sep 13, 2024
28d5378
Merge pull request #1711 from quadratichq/datetime
davidkircos Sep 13, 2024
cafae39
Merge pull request #1781 from quadratichq/datetime-autocomplete
davidkircos Sep 13, 2024
d6e8b9b
delete comments
AyushAgrawal-A2 Sep 16, 2024
0649109
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/rend…
AyushAgrawal-A2 Sep 16, 2024
46ac83c
Merge pull request #1865 from quadratichq/ayush/rendering_bugs
davidkircos Sep 16, 2024
d8880c0
fixing date time issues
davidfig Sep 17, 2024
68849aa
fix bug with date_format; added tests to rust-client/date_time
davidfig Sep 17, 2024
af822f3
fix bug with custom date + calendar selecting
davidfig Sep 17, 2024
97e9c6e
tweak from PR comments
davidfig Sep 17, 2024
e1a4e09
Merge pull request #1872 from quadratichq/fix-datetime-issues
davidfig Sep 17, 2024
7470279
fix: rendering bug due to slow viewport buffer update
AyushAgrawal-A2 Sep 17, 2024
40f5164
clippy
AyushAgrawal-A2 Sep 18, 2024
16265bc
Merge pull request #1874 from quadratichq/ayush/viewport_buffer_bug
davidkircos Sep 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .clabot
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"dependabot",
"dependabot[bot]",
"AyushAgrawal-A2",
"golok727"
"golok727",
"github-actions[bot]@users.noreply.github.com"
],
"message": "We require contributors to sign our Contributor License Agreement, and we don\"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact."
}
45 changes: 45 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,48 @@ jobs:
npm run lint:prettier
npm run lint:eslint
npm run lint:ts

check-version-increment:
runs-on: ubuntu-latest
# If we are merging into main, but not pushed on main
if: github.base_ref == 'main' && github.ref != 'refs/heads/main'
steps:
- name: Checkout current branch
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Get current VERSION
id: current_version
run: echo "CURRENT_VERSION=$(cat VERSION)" >> $GITHUB_OUTPUT

- name: Checkout main branch
uses: actions/checkout@v3
with:
ref: main
fetch-depth: 1

- name: Get main VERSION
id: main_version
run: echo "MAIN_VERSION=$(cat VERSION)" >> $GITHUB_OUTPUT

- name: Compare versions to main, verify this version is higher
run: |
current_version="${{ steps.current_version.outputs.CURRENT_VERSION }}"
main_version="${{ steps.main_version.outputs.MAIN_VERSION }}"
if [ "$(printf '%s\n' "$main_version" "$current_version" | sort -V | tail -n1)" != "$current_version" ]; then
echo "Error: VERSION in the current branch ($current_version) is not greater than VERSION in main ($main_version)"
exit 1
else
echo "VERSION check passed: Current branch ($current_version) > main ($main_version)"
fi

check-versions-match:
runs-on: ubuntu-latest

steps:
- name: Checkout current branch
uses: actions/checkout@v3

- name: Verify that all versions match
run: ./bump.sh verify
44 changes: 44 additions & 0 deletions .github/workflows/production-bump-version.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Bump Version on PR against to main

on:
workflow_dispatch:
inputs:
bump_type:
description: 'Type of version bump'
default: patch
type: choice
options:
- major
- minor
- patch
pull_request:
types: [opened]
branches:
- main

jobs:
bump-version:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Install jq
run: sudo apt-get install jq

- name: Run bump.sh script
run: ./bump.sh ${{ github.event.inputs.bump_type || 'patch' }}

- name: Commit and push changes
run: |
git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
git add .
git commit -m 'Bump version' || exit 0
git pull --rebase
git push
7 changes: 4 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ quadratic-shared/*.js

# misc
.DS_Store
.env
.env.local
.env.development.local
.env.test.local
.env.production.local
.env.old

npm-debug.log*
yarn-debug.log*
Expand All @@ -31,9 +33,6 @@ venv/*
*.pyc
.idea

.env
.env.local

# Generated Rust files
/target
quadratic-connection/target/
Expand Down Expand Up @@ -71,3 +70,5 @@ docker/mssql-connection/data

# JMeter
jmeter.log

~$*
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@
"Signin",
"smallpop",
"Southborough",
"Strftime",
"szhsin",
"thiserror",
"Timelike",
"unspill",
"vals",
"websockets",
Expand Down Expand Up @@ -78,5 +80,8 @@
},
"[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
}
Loading
Loading