feat: add claude-3.5-sonnet to ai assistant in code editor #1855
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #1855 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 208 208
Lines 43349 43349
=======================================
Hits 39415 39415
Misses 3934 3934 ☔ View full report in Codecov by Sentry. |
|
Added to Heroku staging, and production. It's worth noting that going forward all external APIs in every service should be optional for self hosting. If a user self-hosts and doesn't include an ANTHROPIC_API_KEY, it should be disabled in the app. Same with OPEN_AI and every other external service |
|
Quick inital feedback. The first time I used Claude in Python, it gave me Javascript code. The margin between Avatar and the text is different. |
| response.write(`data: ${JSON.stringify(chunk)}\n\n`); | ||
| } | ||
|
|
||
| response.write('[DONE]\n\n'); |
There was a problem hiding this comment.
Why write [done] to the stream?
There was a problem hiding this comment.
works without it, I think it was part of some old api
https://platform.openai.com/docs/api-reference/chat/create#chat-create-stream
| [consoleOutput, editorContent, schemaJsonForAi, selectedCell.x, selectedCell.y, mode] | ||
| ); | ||
|
|
||
| const cellContext = useMemo<AIMessage>( |
There was a problem hiding this comment.
Is this sent with every message?
Should we also add the editor content in addition to the console output?
There was a problem hiding this comment.
ai chat api is stateless, entire prompt history, including even quadratic docs is sent in every api request
editor content is already being sent here
| @@ -249,6 +235,20 @@ ${QuadraticDocs}`, | |||
| <div id="ai-streaming-output-anchor" key="ai-streaming-output-anchor" /> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div className="flex flex-col items-end gap-2 px-3 pb-2"> | |||
| <select | |||
There was a problem hiding this comment.
use shadcn dropdown https://ui.shadcn.com/docs/components/dropdown-menu
requires adding anthropic api key to deployment, in quadratic-api env variables