Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Sept 19 #1892

Merged
merged 178 commits into from
Sep 24, 2024

Merge pull request #1911 from quadratichq/jim-fix-border-menu

207fca6
Select commit
Loading
Failed to load commit list.
Merged

QA: Sept 19 #1892

Merge pull request #1911 from quadratichq/jim-fix-border-menu
207fca6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 23, 2024 in 0s

91.11% (+0.16%) compared to e1a4e09

View this Pull Request on Codecov

91.11% (+0.16%) compared to e1a4e09

Details

Codecov Report

Attention: Patch coverage is 94.60581% with 52 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (e1a4e09) to head (207fca6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
quadratic-core/src/grid/file/v1_5/run_error.rs 0.00% 20 Missing ⚠️
quadratic-core/src/values/cellvalue.rs 92.59% 14 Missing ⚠️
quadratic-core/src/values/time.rs 98.36% 6 Missing ⚠️
quadratic-core/src/controller/viewport.rs 0.00% 5 Missing ⚠️
quadratic-core/src/values/convert.rs 75.00% 3 Missing ⚠️
quadratic-core/src/controller/send_render.rs 66.66% 1 Missing ⚠️
quadratic-core/src/error_run.rs 92.30% 1 Missing ⚠️
quadratic-core/src/formulas/functions/operators.rs 99.68% 1 Missing ⚠️
quadratic-core/src/values/from_js.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   90.95%   91.11%   +0.16%     
==========================================
  Files         220      220              
  Lines       46068    46968     +900     
==========================================
+ Hits        41901    42796     +895     
- Misses       4167     4172       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov