Data tables v1 #1915
Open
Data tables v1 #1915
+32,532
−11,234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #1915 +/- ##
==========================================
- Coverage 90.02% 87.37% -2.65%
==========================================
Files 343 387 +44
Lines 66758 76426 +9668
==========================================
+ Hits 60099 66779 +6680
- Misses 6659 9647 +2988 ☔ View full report in Codecov by Sentry. |
It makes a massive diff because most people on the team aren't using the nightly formatter (understandably).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main branch for merging data table related work.
Closes #1412
closes #2184
closes #2191
closes #2213
closes #2245
Issues tracked here: https://app.quadratichq.com/file/5a2ee1de-6c95-4cc7-af6a-755b94746667
Preview URL: https://data-tables-v1.quadratic-preview.com/