Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AI Research #1963

Open
wants to merge 80 commits into
base: data-tables-v1
Choose a base branch
from
Open

feat: AI Research #1963

wants to merge 80 commits into from

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Oct 11, 2024

closes #2068

https://ayush-ai-researcher.quadratic-preview.com/

  • Enable disable "AI Researcher (exa subprocessor) in settings @jimniels
  • Prompt logging
  • AI Formulas vs UI? It should act like a formula when it's a formula, and a Research cell when it's a researcher cell.
  • UI: styles for "Settings" form controls @jimniels
  • UI: async loading indicators when prompt is sent (happening now in the sheet, but not in the code editor like JS/Python)
  • UI: better error messages
  • UI: remove "Fix in AI" button?

Copy link

qa-wolf bot commented Oct 11, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2024
@AyushAgrawal-A2 AyushAgrawal-A2 self-assigned this Oct 11, 2024
@AyushAgrawal-A2 AyushAgrawal-A2 added the prototype exploring an idea that can be played with label Oct 11, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1963 October 11, 2024 13:31 Inactive
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 94.07666% with 68 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (671775c) to head (a642391).

Files with missing lines Patch % Lines
...controller/execution/run_code/run_ai_researcher.rs 94.57% 48 Missing ⚠️
quadratic-core/src/a1/js_selection/query.rs 0.00% 7 Missing ⚠️
...adratic-core/src/grid/file/serialize/cell_value.rs 41.66% 7 Missing ⚠️
quadratic-core/src/grid/js_types.rs 90.00% 2 Missing ⚠️
...re/src/controller/execution/control_transaction.rs 93.75% 1 Missing ⚠️
...atic-core/src/controller/execution/run_code/mod.rs 50.00% 1 Missing ⚠️
...dratic-core/src/controller/operations/clipboard.rs 98.94% 1 Missing ⚠️
quadratic-core/src/grid/file/v1_7_1/upgrade.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           data-tables-v1    #1963      +/-   ##
==================================================
+ Coverage           89.56%   89.64%   +0.08%     
==================================================
  Files                 388      390       +2     
  Lines               75222    76297    +1075     
==================================================
+ Hits                67373    68398    +1025     
- Misses               7849     7899      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1963 October 11, 2024 16:08 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1963 October 11, 2024 17:02 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1963 October 29, 2024 16:58 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1963 October 29, 2024 17:15 Inactive
@AyushAgrawal-A2 AyushAgrawal-A2 changed the base branch from qa to ayush/move_spill October 29, 2024 17:15
Base automatically changed from ayush/move_spill to ayush/ai_panel November 5, 2024 12:17
Base automatically changed from ayush/ai_panel to qa November 12, 2024 00:11
@github-actions github-actions bot temporarily deployed to preview January 19, 2025 08:02 Destroyed
@quadratichq quadratichq deleted a comment from github-actions bot Jan 19, 2025
@github-actions github-actions bot temporarily deployed to preview January 19, 2025 08:18 Destroyed
@github-actions github-actions bot temporarily deployed to preview January 19, 2025 09:12 Destroyed
@jimniels
Copy link
Collaborator

CleanShot 2025-01-20 at 14 47 11@2x

Two comments here on an experience I had (locally):

  1. THere's no error message (I had didn't have an API token, so that's why it wasn't working, but seems like we should have a generic error message like "Something went wrong. Try again or contact support"
  2. Should we have a "Fix in AI" button? There's not "AI Assistant" tab for this, do we really want an AI helping write/fix prompts that go to AI?

@github-actions github-actions bot temporarily deployed to preview January 21, 2025 09:17 Destroyed
@github-actions github-actions bot temporarily deployed to preview January 21, 2025 09:29 Destroyed
@github-actions github-actions bot temporarily deployed to preview January 21, 2025 12:34 Destroyed
@davidkircos davidkircos added the status: open question Unclear - needs better defined before becoming a high prio issue label Jan 21, 2025
@davidkircos davidkircos changed the title feat: AI Researcher feat: AI Research Jan 21, 2025
@github-actions github-actions bot temporarily deployed to preview January 21, 2025 20:02 Destroyed
Base automatically changed from ai-prompt-logging to qa January 22, 2025 23:55
@AyushAgrawal-A2 AyushAgrawal-A2 changed the base branch from qa to data-tables-v1 January 23, 2025 07:18
@github-actions github-actions bot temporarily deployed to preview January 23, 2025 09:53 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: open question Unclear - needs better defined before becoming a high prio issue status: requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Researcher
3 participants