Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Jan 6th #2158

Merged
merged 32 commits into from
Jan 10, 2025
Merged

QA: Jan 6th #2158

merged 32 commits into from
Jan 10, 2025

Conversation

davidkircos
Copy link
Collaborator

No description provided.

dependabot bot and others added 7 commits December 12, 2024 19:27
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Merge pull request #2108 from quadratichq/qa
Copy link

qa-wolf bot commented Jan 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jan 10, 2025 1:47am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 6, 2025 19:20 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 6, 2025 19:20 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 7, 2025 22:23 Inactive
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 95.06897% with 143 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (a26883a) to head (b0e7aff).
Report is 722 commits behind head on main.

Files with missing lines Patch % Lines
...uadratic-core/src/controller/operations/borders.rs 57.47% 91 Missing ⚠️
quadratic-core/src/formulas/cell_ref.rs 57.14% 21 Missing ⚠️
quadratic-core/src/grid/code_cell.rs 92.79% 8 Missing ⚠️
quadratic-core/src/grid/cells_accessed.rs 0.00% 5 Missing ⚠️
quadratic-core/src/formulas/ctx.rs 89.74% 4 Missing ⚠️
...ore/src/controller/execution/run_code/get_cells.rs 98.50% 2 Missing ⚠️
quadratic-core/src/controller/send_render.rs 0.00% 2 Missing ⚠️
...uadratic-core/src/grid/contiguous/contiguous_2d.rs 96.36% 2 Missing ⚠️
...ratic-core/src/grid/sheet/borders/borders_query.rs 96.07% 2 Missing ⚠️
...rc/grid/sheet_formatting/sheet_formatting_query.rs 98.46% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   90.82%   89.05%   -1.77%     
==========================================
  Files         260      306      +46     
  Lines       57583    62381    +4798     
==========================================
+ Hits        52297    55554    +3257     
- Misses       5286     6827    +1541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…oid-3.3.8

Bump nanoid from 3.3.7 to 3.3.8
…ss-spawn-7.0.6

Bump cross-spawn from 7.0.3 to 7.0.6
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 7, 2025 22:41 Inactive
Add `EDATE()` and `EOMONTH()` formula functions
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 7, 2025 22:57 Inactive
feat: support duplicating example files from outside the app
Copy link

qa-wolf bot commented Jan 8, 2025

E2E tests

  • Last tested commit: b0e7aff

Steps:

  1. When you're ready for a review, click the button to run E2E tests.
  2. If you pushed commits after tests finished, re-run them before merging.

🐺 If tests fail, you can relax and do nothing: your wolf pack will investigate.

Results

undefined 2 blocking bugs

Ran Status Preview Started Run time Est. dev time saved
99 workflows Done (Details) Jan 8, 2025 at 7:07 PM (UTC) 23 minutes ~40.17 hrs
99 workflows Done (Details) Jan 9, 2025 at 6:41 PM (UTC) 23 minutes ~40.17 hrs
99 workflows Done (Details) Jan 9, 2025 at 11:48 PM (UTC) 23 minutes ~40.17 hrs

Latest run

✅ 93 passed

Preexisting bugs

2 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

fix: copy-paste a code cell isn't changing relative reference if sheet name is included
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2158 January 9, 2025 23:17 Inactive
@davidkircos davidkircos merged commit 927f1a7 into main Jan 10, 2025
16 of 19 checks passed
davidkircos added a commit that referenced this pull request Jan 10, 2025
Merge pull request #2158 from quadratichq/qa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants