-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unsafe unwraps #2251
fix: unsafe unwraps #2251
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Preview - Build & Deploy Images✅ Build images 🕒 Last deployed: Jan 30, 2025 at 05:12 PM UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## qa #2251 +/- ##
==========================================
- Coverage 90.02% 90.02% -0.01%
==========================================
Files 343 343
Lines 66758 66761 +3
==========================================
+ Hits 60099 60100 +1
- Misses 6659 6661 +2 ☔ View full report in Codecov by Sentry. |
@@ -101,7 +101,7 @@ impl Connection for MsSqlConnection { | |||
if let Some(username) = &self.username { | |||
config.authentication(AuthMethod::sql_server( | |||
username, | |||
self.password.as_ref().unwrap(), | |||
self.password.as_deref().unwrap_or_default(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can return an error here (just like we do in port
above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.