Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsafe unwraps #2251

Merged
merged 6 commits into from
Jan 31, 2025
Merged

fix: unsafe unwraps #2251

merged 6 commits into from
Jan 31, 2025

Conversation

AyushAgrawal-A2
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Jan 30, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview - Build & Deploy Images

✅ Build images
✅ Deploy images

🕒 Last deployed: Jan 30, 2025 at 05:12 PM UTC

🔗 URL: https://ayush-fix-unwrap.quadratic-preview.com

@github-actions github-actions bot temporarily deployed to preview-pr-2251 January 30, 2025 15:49 Destroyed
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (026b02d) to head (5e75fb1).
Report is 7 commits behind head on qa.

Files with missing lines Patch % Lines
quadratic-files/src/server.rs 0.00% 1 Missing ⚠️
quadratic-rust-shared/src/sql/mssql_connection.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #2251      +/-   ##
==========================================
- Coverage   90.02%   90.02%   -0.01%     
==========================================
  Files         343      343              
  Lines       66758    66761       +3     
==========================================
+ Hits        60099    60100       +1     
- Misses       6659     6661       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr-2251 January 30, 2025 15:56 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2251 January 30, 2025 16:05 Destroyed
@@ -101,7 +101,7 @@ impl Connection for MsSqlConnection {
if let Some(username) = &self.username {
config.authentication(AuthMethod::sql_server(
username,
self.password.as_ref().unwrap(),
self.password.as_deref().unwrap_or_default(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can return an error here (just like we do in port above).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions bot temporarily deployed to preview-pr-2251 January 30, 2025 16:17 Destroyed
@AyushAgrawal-A2 AyushAgrawal-A2 merged commit 1148899 into qa Jan 31, 2025
22 of 23 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/fix_unwrap branch January 31, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants