Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Chart Support #846

Merged
merged 86 commits into from
Dec 4, 2023
Merged

feat: Chart Support #846

merged 86 commits into from
Dec 4, 2023

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Nov 19, 2023

  • html w/h should be f32 so it better matches with gridLines
  • escape key cancels resizing of html
  • bug: HTML does not properly remove when no longer returning an HTML value
  • bug when changing html -- zoom events are no longer caught properly
  • bug: code editor / terminal can't be resized
  • bug with spills :(
  • snap to grid
  • change "HTML" label to "CHART"
  • try changing border to same as code cell output
  • panning and zooming the viewport when hovering over html and div
  • thumbnail placeholders
  • html support for python cells
  • resizing html
  • div support for python cells (sort of working)
  • resizing div
  • update html for changes
  • duplicate sheets w/html
  • rename OutputSize to RenderSize
  • returning a plotly object should call to_html()
  • fix pinch zooming the entire document
  • add highlight color when hovering over resize edges
  • code comments and tests

later

  • bug: when resizing a column that would move a chart. the chart doesn't move until the page is reloaded
  • default to no icon bar, just pointer hovers for charts { 'displaylogo': False, 'displayModeBar': True }
  • heading is behind HTML -- may need another renderer just for column/row headings
  • .show() support
  • snapping (removed in build since it was not exact)

launch

  • Update examples
  • Update docs
  • Update marketing website

Copy link

vercel bot commented Nov 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Dec 4, 2023 6:51pm

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (194e84b) 88.18% compared to head (b5286f3) 88.52%.

❗ Current head b5286f3 differs from pull request most recent head c997abf. Consider uploading reports for the commit c997abf to get more accurate results

Files Patch % Lines
quadratic-core/src/grid/file/current.rs 43.90% 23 Missing ⚠️
quadratic-core/src/position.rs 0.00% 9 Missing ⚠️
quadratic-core/src/grid/code.rs 50.00% 5 Missing ⚠️
quadratic-core/src/values/cellvalue.rs 63.63% 4 Missing ⚠️
quadratic-core/src/controller/formatting.rs 92.50% 3 Missing ⚠️
...atic-core/src/controller/update_code_cell_value.rs 88.88% 2 Missing ⚠️
quadratic-core/src/values/convert.rs 0.00% 2 Missing ⚠️
quadratic-core/src/controller/operations.rs 93.75% 1 Missing ⚠️
quadratic-core/src/formulas/criteria.rs 0.00% 1 Missing ⚠️
quadratic-core/src/grid/formatting.rs 88.88% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   88.18%   88.52%   +0.33%     
==========================================
  Files          99       99              
  Lines       17327    17765     +438     
==========================================
+ Hits        15280    15726     +446     
+ Misses       2047     2039       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 November 20, 2023 13:29 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 November 21, 2023 13:58 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 20:13 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 20:30 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 20:33 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 20:33 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 23:10 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 1, 2023 23:57 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-846 December 4, 2023 18:16 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-846 December 4, 2023 18:46 Inactive
@davidkircos davidkircos merged commit e4dbfea into main Dec 4, 2023
6 checks passed
@davidkircos davidkircos deleted the plotly branch December 4, 2023 18:53
@davidfig davidfig restored the plotly branch December 5, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Graphics (Charts and Graphs) from Python
5 participants