-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round to 9 decimal places for formulas w/o a user-set decimal places #893
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 88.16% 88.18% +0.02%
==========================================
Files 99 99
Lines 17317 17327 +10
==========================================
+ Hits 15267 15280 +13
+ Misses 2050 2047 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was an issue in the summary where we convert to a f64 after rounding that introduced unwanted behavior.....because floats. I added a round function for working directly f64s to mitigate this. |
Addresses #877