Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP transactions #912

Merged
merged 285 commits into from
Dec 17, 2023
Merged

MP transactions #912

merged 285 commits into from
Dec 17, 2023

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Dec 4, 2023

No description provided.

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Dec 17, 2023 1:31pm

@davidfig davidfig changed the base branch from main to basic-ws-server December 4, 2023 20:21
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 20:21 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 20:58 Inactive
@davidkircos davidkircos had a problem deploying to quadratic-api-dev-pr-912 December 4, 2023 21:10 Failure
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 21:10 Inactive
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 262 lines in your changes are missing coverage. Please review.

Comparison is base (933735f) 88.47% compared to head (a6cffb6) 89.39%.
Report is 5 commits behind head on a-team.

❗ Current head a6cffb6 differs from pull request most recent head bd773f9. Consider uploading reports for the commit bd773f9 to get more accurate results

Files Patch % Lines
quadratic-core/src/controller/execution/compute.rs 81.81% 60 Missing ⚠️
...ratic-core/src/controller/operations/formatting.rs 68.24% 47 Missing ⚠️
...dratic-core/src/controller/operations/clipboard.rs 90.95% 19 Missing ⚠️
quadratic-core/src/grid/borders/sheet.rs 89.18% 16 Missing ⚠️
...re/src/controller/execution/control_transaction.rs 94.67% 13 Missing ⚠️
...atic-core/src/controller/execution/eval_formula.rs 74.00% 13 Missing ⚠️
...uadratic-core/src/controller/user_actions/cells.rs 92.40% 12 Missing ⚠️
...adratic-core/src/controller/user_actions/sheets.rs 93.02% 9 Missing ⚠️
...ratic-core/src/controller/operations/cell_value.rs 91.48% 8 Missing ⚠️
quadratic-core/src/controller/operations/sheets.rs 87.87% 8 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           a-team     #912      +/-   ##
==========================================
+ Coverage   88.47%   89.39%   +0.92%     
==========================================
  Files         105      127      +22     
  Lines       18205    19135     +930     
==========================================
+ Hits        16106    17106    +1000     
+ Misses       2099     2029      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 21:31 Inactive
Base automatically changed from basic-ws-server to a-team December 4, 2023 22:06
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 22:59 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 4, 2023 23:11 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 5, 2023 01:37 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 5, 2023 16:47 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 15, 2023 13:49 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 15, 2023 14:31 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 17, 2023 13:22 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 17, 2023 13:25 Inactive
@davidfig davidfig marked this pull request as ready for review December 17, 2023 13:27
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-912 December 17, 2023 13:27 Inactive
@davidfig davidfig merged commit cabf260 into a-team Dec 17, 2023
2 of 8 checks passed
@davidfig davidfig deleted the mp-transaction branch December 17, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants