Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASP Wann90 interface #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

VASP Wann90 interface #129

wants to merge 3 commits into from

Conversation

isamathr
Copy link

Create the input file of wanniertools software based on VASP and Wannier90 output

The Process requires

  1. A self consistent calculation with VASP
  2. Wannier functions construction with Wannier90
  3. Band structure calculation with VASP

Creation of the wt.in file based on VASP and Wannier90 output files.
@quanshengwu
Copy link
Owner

Dear Ilias,

Thanks for joining the development of WannierTools.

I read your code create_wanniertools_input.py. It's well written. I like it.
Before merging it into the master branch, could you please make the code more user-friendly?

  1. Provide a user guide at the top of create_wanniertools_input.py.
  2. For all parameters, It's better setting a default value such that this script can be run to generate a wt.in file. For user, it will be frustrated if there is no output.
    Best,
    Quansheng

Added user guide and default parameters
@isamathr
Copy link
Author

Dear Quansheng,

Thank you for your kind words.
I modified the code to make it more user friendly according to your suggestions. You can have a look at the updated file 'create_wanniertools_input.py'

Best regards,
Ilias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants