Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Drupal 10.1 CSS/JS aggregation issues. #190

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

kepol
Copy link
Contributor

@kepol kepol commented Sep 28, 2023

See d.o issue: https://www.drupal.org/project/quantcdn/issues/3390296

Note that Stu provided the basic functionality via Slack. I've tested it on 10.1 through UI and drush by seeding theme assets.

@kepol kepol added bug Something isn't working Drupal 8 / 9 / 10 needs review labels Sep 28, 2023
@steveworley steveworley self-requested a review September 29, 2023 03:47
Copy link
Contributor

@steveworley steveworley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on the strpos and the regex — str_starts_with and str_ends_with make the code easier to grok.

Thanks!

@kepol
Copy link
Contributor Author

kepol commented Sep 29, 2023

Adjust logic and tested again on 10.1 and it's working fine so I'll merge this.

@kepol kepol merged commit e793d24 into 8.x-1.x Sep 29, 2023
2 checks passed
@kepol
Copy link
Contributor Author

kepol commented Sep 29, 2023

Included in 1.5.4 release.

@kepol kepol deleted the feature/d10-aggregation branch November 5, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Drupal 8 / 9 / 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants