DRAFT Drupal 11 compatibility. #191

kepol · 2023-09-29T07:26:37Z

We shouldn't merge this yet because some of our dependencies are D11 compatible yet. Moving this to draft for now.

https://www.drupal.org/project/simple_sitemap - not compatible asf 5 Jul 2024 [D11 issue]
https://www.drupal.org/project/tome - not compatible as of 5 Jul 2024 [D11 issue]
https://www.drupal.org/project/webform - not compatible as of 5 Jul 2024 [D11 issue]
https://www.drupal.org/project/token - dev version is compatible as of 18 May 2024
https://www.drupal.org/project/purge - compatible as of 28 Jun 2024

Although we don't need to provide D11 support yet, there are quite a few modules that already do support D11. Someone provided a patch so I decided to test it. It worked with one minor tweak.

See d.o issue: https://www.drupal.org/project/quantcdn/issues/3389070

steveworley

Looks good, we might just need to do a little testing on the self::MAIN_REQUEST change in the Url registrar class to ensure its compatible with d9/10.

modules/quant_purger/src/StackMiddleware/UrlRegistrar.php

kepol · 2023-09-29T10:14:24Z

I did a quick test using Umami for D9.5, D10, D10.1 and D11 and they all seemed fine other than D11 didn't process the webp image on the /recipes page. Not sure why that's webp anyway. I didn't see anything obvious in the core issue queue but I assume it's a bug in core.

src="/sites/default/files/styles/scale_crop_7_3_medium/public/vegan-brownies-hero-umami.jpg.webp?itok=A9_Np84o"

kepol · 2023-09-29T10:15:05Z

@steveworley Would you prefer we merge this or park it until later given thewebp issue?

UPDATE: Note that page/image looks fine on the Drupal side.

steveworley · 2023-10-18T00:50:44Z

I think we should try and see if we can resolve the webp issue before merging. I haven't had a chance to dig in just yet.

kepol · 2023-10-31T22:14:50Z

Sounds good. Moved this to draft for now.

kepol · 2024-01-04T02:09:19Z

Updated D11 test site and tested again and am seeing that this may be a responsive image issue or an Umami profile issue. I see the webp image at some widths and not others. I see webp images in Quant.

The markup has:

                  <source srcset="/sites/default/files/styles/scale_crop_7_3_wide/public/vegan-brownies-hero-umami.jpg.webp?itok=mOV_7Acn 1x" media="all and (min-width: 1400px)" type="image/webp" width="3000" height="1285">
              <source srcset="/sites/default/files/styles/scale_crop_7_3_large/public/vegan-brownies-hero-umami.jpg.webp?itok=0_b82U2r 1x" media="all and (min-width: 800px) and (max-width: 1400px)" type="image/webp" width="1440" height="617">
              <source srcset="/sites/default/files/styles/scale_crop_7_3_medium/public/vegan-brownies-hero-umami.jpg.webp?itok=A9_Np84o 1x" media="all and (min-width: 500px) and (max-width: 800px)" type="image/webp" width="1200" height="514">
              <source srcset="/sites/default/files/styles/scale_crop_7_3_tiny/public/vegan-brownies-hero-umami.jpg.webp?itok=DI5cHAO5 1x" media="all" type="image/webp" width="500" height="214">

And Quant has:

kepol · 2024-01-04T02:42:56Z

It looks like this is where the Umami profile got the responsive images (webp) added:

https://www.drupal.org/project/drupal/issues/3349447#comment-15184905

kepol · 2024-01-04T03:23:01Z

It doesn't seem to be a Quant issue. Once the responsive images are generated in Drupal, they do get seeded. For some reason the scale_crop_7_3_tiny image isn't getting created on the Drupal side so it generates an error log but the other 3 do show up.

kepol · 2024-01-04T03:31:14Z

Okay... used emulator to go more narrow and then tiny showed up and was seeded. So... the main issue is that for some reason the Quant code in src/Plugin/QueueItem/FileItem.php to generate the image styles (if they don't exist) isn't working for these. The image styles will only get seeded if they've already been generated.

kepol · 2024-01-04T03:43:11Z

I think I figured it out. In some cases, the Quant code is pulling in the 1x into the filename which is probably what is screwing up the image style generation, e.g.

/sites/default/files/styles/scale_crop_7_3_tiny/public/vegan-brownies-hero-umami.jpg.webp?itok=DI5cHAO5 1x

I assume this is during the parsing the srcset. I'll see if I can find the regex for that.

kepol · 2024-01-04T04:46:55Z

Added a work around to this PR. To test, I got rid of the various image styles for the recipes page and then seeded views so they would be picked up. The code now generates all the image styles properly.

Made changes since this time.

kepol · 2024-01-04T05:25:01Z

Stu mentioned that the responsive image issue might be better fixed elsewhere but I'll leave the code here for now. I did test it using an image with spaces.

steveworley · 2024-01-08T02:56:14Z

src/Plugin/QueueItem/FileItem.php

+
+    // Handle responsive images by removing extraneous data like ` 1x`.
+    // @todo Fix this in the Quant infrastructure.
+    if ($this->fullPath) {


This code looks fine, but I'm not sure why were transforming path on disk — do image styles not include the 1x when resaving?

@steveworley We're not changing the path on disk afaik. In some situations (unknown why, assume a core bug), when you get the "full_path", it shows a space and then 1x at the end even though that is not correct and should not be there. I assume there is some bug somewhere parsing the srcset value.

Stu said he will handle this at some point on the infra side, but this is just a workaround for now.

Without this workaround, then some of the image styles may not be created if they don't exist already.

kepol · 2024-01-20T02:48:59Z

We shouldn't merge this yet because some of our dependencies are D11 compatible yet. Moving this to draft for now.

https://www.drupal.org/project/purge - not compatible as of 19 Jan 2024
https://www.drupal.org/project/simple_sitemap - not compatible as of 19 Jan 2024
https://www.drupal.org/project/token - not compatible as of 19 Jan 2024
https://www.drupal.org/project/tome - not compatible as of 19 Jan 2024
https://www.drupal.org/project/webform - not compatible as of 19 Jan 2024

kepol · 2024-07-06T01:55:42Z

Updated the issue with the D11 status of module dependencies. Still waiting on 3 of them.

kepol added 3 commits September 28, 2023 20:00

Drupal 11 compatibility.

efb0b00

Add empty validateForm to prevent fatal error.

1f82346

Merge branch '8.x-1.x' into feature/d11-compatibility

638dd5a

kepol added Drupal 8 / 9 / 10 needs review task labels Sep 29, 2023

kepol requested a review from steveworley September 29, 2023 07:27

steveworley approved these changes Sep 29, 2023

View reviewed changes

modules/quant_purger/src/StackMiddleware/UrlRegistrar.php Show resolved Hide resolved

steveworley previously approved these changes Oct 18, 2023

View reviewed changes

kepol marked this pull request as draft October 31, 2023 22:14

kepol added needs work and removed needs review labels Oct 31, 2023

kepol changed the title ~~Drupal 11 compatibility.~~ DRAFT Drupal 11 compatibility. Nov 2, 2023

kepol self-assigned this Nov 2, 2023

Merge branch '8.x-1.x' into feature/d11-compatibility

a8e2101

Worked around issue with responsive image paths.

4bb801f

kepol added needs review and removed needs work labels Jan 4, 2024

kepol requested a review from steveworley January 4, 2024 04:48

kepol marked this pull request as ready for review January 4, 2024 04:48

kepol changed the title ~~DRAFT Drupal 11 compatibility.~~ Drupal 11 compatibility. Jan 4, 2024

Added todo for infrastructure fix.

10755ff

steveworley reviewed Jan 8, 2024

View reviewed changes

Merge branch '8.x-1.x' into feature/d11-compatibility

6152bd0

kepol marked this pull request as draft January 20, 2024 02:49

kepol changed the title ~~Drupal 11 compatibility.~~ DRAFT Drupal 11 compatibility. Jan 20, 2024

kepol removed their assignment Jan 20, 2024

kepol added postponed and removed needs review labels Jan 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DRAFT Drupal 11 compatibility. #191

DRAFT Drupal 11 compatibility. #191

kepol commented Sep 29, 2023 •

edited

Loading

steveworley left a comment

kepol commented Sep 29, 2023

kepol commented Sep 29, 2023 •

edited

Loading

steveworley commented Oct 18, 2023

kepol commented Oct 31, 2023

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024 •

edited

Loading

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

steveworley Jan 8, 2024

kepol Jan 9, 2024 •

edited

Loading

kepol commented Jan 20, 2024

kepol commented Jul 6, 2024

DRAFT Drupal 11 compatibility. #191

Are you sure you want to change the base?

DRAFT Drupal 11 compatibility. #191

Conversation

kepol commented Sep 29, 2023 • edited Loading

steveworley left a comment

Choose a reason for hiding this comment

kepol commented Sep 29, 2023

kepol commented Sep 29, 2023 • edited Loading

steveworley commented Oct 18, 2023

kepol commented Oct 31, 2023

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024 • edited Loading

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

kepol commented Jan 4, 2024

steveworley Jan 8, 2024

Choose a reason for hiding this comment

kepol Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

kepol commented Jan 20, 2024

kepol commented Jul 6, 2024

kepol commented Sep 29, 2023 •

edited

Loading

kepol commented Sep 29, 2023 •

edited

Loading

kepol commented Jan 4, 2024 •

edited

Loading

kepol Jan 9, 2024 •

edited

Loading