Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for empty language prefix. #225

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Added check for empty language prefix. #225

merged 1 commit into from
Jan 31, 2024

Conversation

kepol
Copy link
Contributor

@kepol kepol commented Jan 31, 2024 •
edited
Loading

See details in Drupal.org issue:

https://www.drupal.org/project/quantcdn/issues/3418192

Before

 [notice] [route_item] /articles
 [notice] [route_item] //articles
 [notice] [route_item] /es/articles
 [notice] [route_item] //node
 [notice] [route_item] /es/node
 [notice] [route_item] /recipes
 [notice] [route_item] //recipes
 [notice] [route_item] /es/recipes

After

 [notice] [route_item] /articles
 [notice] [route_item] /es/articles
 [notice] [route_item] /node
 [notice] [route_item] /es/node
 [notice] [route_item] /recipes
 [notice] [route_item] /es/recipes

and if you add the prefix back in:

 [notice] [route_item] /articles
 [notice] [route_item] /en/articles
 [notice] [route_item] /es/articles
 [notice] [route_item] /node
 [notice] [route_item] /en/node
 [notice] [route_item] /es/node
 [notice] [route_item] /recipes
 [notice] [route_item] /en/recipes
 [notice] [route_item] /es/recipes

@kepol kepol self-assigned this Jan 31, 2024
@kepol kepol added bug Something isn't working Drupal 8 / 9 / 10 needs review labels Jan 31, 2024
@kepol kepol requested a review from steveworley January 31, 2024 00:39
@kepol kepol merged commit 48f0a25 into 8.x-1.x Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveworley steveworley steveworley approved these changes

Assignees

@kepol kepol

Labels
bug Something isn't working Drupal 8 / 9 / 10 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kepol @steveworley