Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for quanteda v4.1.0 #69

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fixes for quanteda v4.1.0 #69

merged 4 commits into from
Sep 3, 2024

Conversation

kbenoit
Copy link
Contributor

@kbenoit kbenoit commented Sep 3, 2024

Imports RcppArmadillo.h directly, as this was removed from the quanteda namespace in 4.1.0.

@kbenoit kbenoit requested a review from koheiw September 3, 2024 03:25
@kbenoit
Copy link
Contributor Author

kbenoit commented Sep 3, 2024

This works with either quanteda 4.1.0 or 4.0.2 installed (the latter is part of the CI checks).

@kbenoit kbenoit merged commit 96c6ae6 into master Sep 3, 2024
6 checks passed
@kbenoit kbenoit deleted the fix-quanteda-v4_1_0 branch September 3, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants