Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should textplot_network() do with asymmetric fcm? #4

Open
koheiw opened this issue Oct 24, 2018 · 1 comment
Open

What should textplot_network() do with asymmetric fcm? #4

koheiw opened this issue Oct 24, 2018 · 1 comment
Assignees

Comments

@koheiw
Copy link
Collaborator

koheiw commented Oct 24, 2018

In relation to quanteda/quanteda#1461, we haven't defined how to deal with an asymmetric fcm. Probably, the lower triangle is ignored in the conversion:
https://github.com/quanteda/quanteda/blob/fe6af954ad31ea9e47b8baacc95a9dd9c8468ca7/R/textplot_network.R#L153-L154
I should warn users or raise error when a fcm is asymmetric.

@kbenoit
Copy link
Contributor

kbenoit commented Oct 24, 2018

This will probably not arise often, because few users will set ordered = TRUE if they are looking to produce network plots. However if they do, I think a warning is appropriate.

@kbenoit kbenoit transferred this issue from quanteda/quanteda Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants