-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove short_name method #934
Remove short_name method #934
Conversation
- Replace with wire_symbol(reg=None)
if reg.name not in self.ctrl_reg_names: | ||
# Delegate to subbloq | ||
print(self.subbloq) | ||
print(type(self.subbloq)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops
One of the motivations was that the author of the Could you add support for this use case? both in the types and docs and in the musical score drawer? |
Would returning I will probably leave modifying the symbols of specific gates to a different PR (also, will only do obvious ones, like arithmetic operators, since I am not super familiar with all of these bloqs) |
I sortof defer to you on how to signal "no label", but whatever it is: it should be documented and the |
@mpharrigan I think this is ready for review. Please let me know if I missed anything. |
For item 2 in #728