Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 web components config version is shared between dependencies #164

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/project.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
release:
current-version: "0.2.2"
current-version: "0.3.0"
next-version: "1.0.0-SNAPSHOT"

2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/includes/attributes.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
:project-version: 0.2.2
:project-version: 0.3.0

:examples-dir: ./../examples/
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,16 @@ String readFile(Format aFormat) {
}

String getHtml(RoutingContext aRoutingContext) {
String version = ConfigProvider.getConfig()
String webComponentVersion = ConfigProvider.getConfig()
.getValue("quarkus.asyncapi.annotation.scanner.webcomponentversion", String.class);
String webComponentJsVersion = ConfigProvider.getConfig()
.getValue("quarkus.asyncapi.annotation.scanner.webcomponentjsversion", String.class);
String reactComponentVersion = ConfigProvider.getConfig()
.getValue("quarkus.asyncapi.annotation.scanner.reactcomponentversion", String.class);
String rootPath = ConfigProvider.getConfig()
.getValue("quarkus.http.root-path", String.class);
//TODO logo
return String.format(HTML_PATTERN, version, version, version, rootPath, rootPath);
return String.format(HTML_PATTERN, webComponentJsVersion, webComponentVersion, reactComponentVersion, rootPath);
}

Format getFormat(RoutingContext aRoutingContext) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,22 @@ public class AsyncApiRuntimeConfig {
*
* @see https://www.npmjs.com/package/@asyncapi/react-component
*/
@ConfigItem(defaultValue = "1.0.0-next.48")
@ConfigItem(defaultValue = "1.2.25")
public String webcomponentversion;
/**
* Version of the ReasComponent to be used in html-view to be found at [HOST]/asyncapi.html
*
* @see https://www.npmjs.com/package/@asyncapi/react-component
*/
@ConfigItem(defaultValue = "1.2.25")
public String reactcomponentversion;
/**
* Version of the WebComponentJS to be used in html-view to be found at [HOST]/asyncapi.html
*
* @see https://www.npmjs.com/package/@webcomponents/webcomponentsjs
*/
@ConfigItem(defaultValue = "2.8.0")
public String webcomponentjsversion;

/**
* Full qualified name of the implementing AsyncApiFilter
Expand Down
Loading