Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading-anchor extension #131

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Oct 23, 2024

This pull request adds support for heading anchor!

It is a great feature for feature features, like searching...

@mkouba
Copy link
Contributor

mkouba commented Oct 23, 2024

Does it make sense to introduce a new extension for this functionality? It could be a functionality of the core markdown extension, probably guarded by a config flag...

@mcruzdev
Copy link
Member Author

Does it make sense to introduce a new extension for this functionality? It could be a functionality of the core markdown extension, probably guarded by a config flag...

I really prefer this approach for the simplicity, it would be enabled by default.

@ia3andy
Copy link
Contributor

ia3andy commented Oct 23, 2024

@mkouba I am also not sure about how to deal with those, but since they are runtime dependencies, better split like this IMO

@mkouba
Copy link
Contributor

mkouba commented Oct 24, 2024

@mkouba I am also not sure about how to deal with those, but since they are runtime dependencies, better split like this IMO

Does it make sense to introduce a new extension for this functionality? It could be a functionality of the core markdown extension, probably guarded by a config flag...

I really prefer this approach for the simplicity, it would be enabled by default.

@mcruzdev @ia3andy I don't think it's reasonable to add a new extension for each major feature. IMO a new extension is adequate if a feature requires a new dependency (another extension or library).

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

It requires a new dependency

@mkouba
Copy link
Contributor

mkouba commented Oct 24, 2024

It requires a new dependency

Ah, sorry I completely missed the commonmark-ext-heading-anchor dependency. So pls ignore my previous comments ;-).

@mcruzdev
Copy link
Member Author

@ia3andy we need to add this feature for asciidoc too. WDYT to add this feature on roq? manipulating the HTML and adding heading IDs? To add a mechanism to change the HTML through plugins too.

@ia3andy ia3andy merged commit aa103d7 into quarkiverse:main Oct 28, 2024
2 checks passed
@mcruzdev
Copy link
Member Author

Hi @mkouba, do you think when you throw the new release?

@mcruzdev mcruzdev deleted the heading-anchor branch October 29, 2024 17:11
@mkouba
Copy link
Contributor

mkouba commented Oct 30, 2024

Hi @mkouba, do you think when you throw the new release?

Once we fine tune and merge #129 ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants