Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #22: Add config for site and data directories #23

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix #22: Add config for site and data directories #23

merged 1 commit into from
Jun 27, 2024

Conversation

melloware
Copy link
Contributor

Fix #22: Add config for site and data directories

@melloware melloware added the enhancement New feature or request label Jun 25, 2024
@melloware
Copy link
Contributor Author

@ia3andy i started this to make sure it was what you were thinking.

@melloware melloware force-pushed the 22 branch 2 times, most recently from ff32882 to b2ee75a Compare June 26, 2024 17:09
@melloware
Copy link
Contributor Author

Refactored to common-deployment let me know how you want me to handle the new data Config that was added to roq-data?

@melloware melloware requested a review from ia3andy June 26, 2024 17:10
ia3andy
ia3andy approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I will use a BuildItem to keep the directories

@ia3andy ia3andy marked this pull request as ready for review June 27, 2024 08:42
@ia3andy ia3andy requested a review from a team as a code owner June 27, 2024 08:42
@ia3andy ia3andy merged commit c08dd21 into main Jun 27, 2024
1 check failed
@ia3andy ia3andy deleted the 22 branch June 27, 2024 08:42
mcruzdev pushed a commit that referenced this pull request Oct 9, 2024
@ia3andy
Merge pull request #23 from quarkiverse/22
81afa82 
Fix #22: Add config for site and data directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees

@ia3andy ia3andy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to use any directory as site root
2 participants
@melloware @ia3andy