Fix #42: RoqObjectMapperBuildItem #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes me think we could just depend on Jackson in deployment, we don't need quarkus-jackson |
|
Ah small detail, we might not need the writing configuration as this is just reading in Roq (AFAIK) |
|
Yeah i wasn't sure the best approach? Also I didn't actually replace the ObjectMapper() in roq-data i wasn't quite sure how to do that so i thought @mcruzdev would be able to do that after this PR is in. |
melloware
force-pushed
the
42-objectmapper
branch
from
19ab31d to
2b1f60e
Compare
melloware
force-pushed
the
42-objectmapper
branch
from
2b1f60e to
bed2f6a
Compare
|
I removed all the "writable" configs so only deserialization configs. |
mcruzdev
pushed a commit
that referenced
this pull request
Oct 9, 2024
Fix #42: RoqObjectMapperBuildItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42: RoqObjectMapperBuildItem
I am not sure I got this right and its definitely not as full featured as the Jackson module.
Should I just use the quarkus jackson config item instead of creating my own?