Update roq-data documentation #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Jul 31, 2024
| public record Data(String name, String description) {} | ||
| ---- | ||
|
|
||
| Inject the `Data` record into a resource class. |
There was a problem hiding this comment.
My only comment is the Data pojo too generic. Should it be something real world like Car. Only because users might think it needs to be called Data or something like that?
melloware
requested changes
Jul 31, 2024
| ---- | ||
| { | ||
| "name": "Gol", | ||
| "age": 1994 |
There was a problem hiding this comment.
Name and age should be "make" and "year" for a Car
melloware
approved these changes
Aug 1, 2024
mcruzdev
force-pushed
the
issue-47
branch
2 times, most recently
from
be50908 to
e76e51d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47