Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle null values in secrets loaded by the credentials provider #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Dec 19, 2024

Fixes #327
Supersedes #329

@vsevel
Copy link
Contributor Author

vsevel commented Jan 8, 2025

hello @kdubb can you give me a quick review? thanks

@vsevel
Copy link
Contributor Author

vsevel commented Jan 22, 2025

hello @sberyozkin can you step in for the review?

Copy link
Contributor

@kdubb kdubb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like a simple change to detect misconfiguration and runtime changes that result in a missing value.

Honestly I didn't even know vault stored null, but since we're getting a map, this will catch requests using non-existent key as well.

@vsevel
Copy link
Contributor Author

vsevel commented Jan 23, 2025

thanks @kdubb
I will rebase and merge
then I am planning to do a release just in time for the next Quarkus LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when retrieving Vault contents with null values
2 participants