Bugfix: IDA mnemonics fallback for architectures not supported by capstone #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 9, 2022 09:34
style: various improvements on the code style
Update copyright to 2023
* Add support for older IDA versions (7.0 - 7.4). Signed-off-by: Dominik Bayerl <[email protected]> * Bugfix. - term-Callback must be nullptr for PLUGIN_MULTI plugins - run-Callback must be nullptr for PLUGIN_MULTI plugins Signed-off-by: Dominik Bayerl <[email protected]> * Remove unrelated change --------- Signed-off-by: Dominik Bayerl <[email protected]> Co-authored-by: Riccardo Mori <[email protected]>
Starting from IDA SDK 8.2 the path of the library on windows changed by
appending the edition ("pro", "teams" and presumably "home").
Fix compatibility with IDA 8.{1,2} and cleanup
Add several APIs
This might cause errors when having a fake chunk as the very last chunk in the code. This might happen when having some orphan asm code at the very end. If we don't resize it, that fake chunk will have end_addr == BADADDR, so it will basically be unlimited. This might result in errors when binary searching for chunks.
Always resize the last chunk
…ted by capstone. quokka.CapstoneErrors are currently not handled appropriately, i.e. if you try to get instruction listings for an architecture not supported by capstone, you receive the error `quokka.exc.CapstoneError: Unable to find the Architecture`. This patch addresses this, by handling quokka.CapstoneError with a proper fallback to the IDA disassembly. Signed-off-by: Dominik Bayerl <[email protected]>
|
N.B.: I am not entirely sure, if this should better be handled here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quokka.CapstoneErrors are currently not handled appropriately, i.e. if you try to get instruction listings for an architecture not supported by capstone, you receive the error
quokka.exc.CapstoneError: Unable to find the Architecture:quokka/bindings/python/quokka/backends/capstone.py
Lines 68 to 71 in 2f1d4cc
This patch addresses this, by handling quokka.CapstoneError with a proper fallback to the IDA disassembly, at least for instruction mnemonics.