Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5.z] Release version 1.5.3 #1326

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[1.5.z] Release version 1.5.3 #1326

merged 1 commit into from
Sep 17, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Sep 17, 2024

Summary

Release version 1.5.3

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

@mocenas how much you are in hurry with this release? I forgot that this #1320 needs to be backported to 1.5.z and bumped in TS otherwise one test will be flaky there. but it's not super urgent, I can make another release later this week.

TL;DR; if you are not in hurry, let's backport #1320 first and rebase this PR on next 1.5.z

@michalvavrik
Copy link
Member

opened #1327 but still, if this is urgent, I can wait

@mocenas
Copy link
Contributor Author

mocenas commented Sep 17, 2024

@mocenas how much you are in hurry with this release? I forgot that this #1320 needs to be backported to 1.5.z and bumped in TS otherwise one test will be flaky there. but it's not super urgent, I can make another release later this week.

TL;DR; if you are not in hurry, let's backport #1320 first and rebase this PR on next 1.5.z

I would like to release it today. If you can merge #1327 soon, I have no problem rebasing this on it.

@michalvavrik
Copy link
Member

@mocenas how much you are in hurry with this release? I forgot that this #1320 needs to be backported to 1.5.z and bumped in TS otherwise one test will be flaky there. but it's not super urgent, I can make another release later this week.
TL;DR; if you are not in hurry, let's backport #1320 first and rebase this PR on next 1.5.z

I would like to release it today. If you can merge #1327 soon, I have no problem rebasing this on it.

cool, I think backport PR should be fine, it depends on OCP CI which I can't influence.

@michalvavrik
Copy link
Member

@mocenas let's rebase, let format validation pass and merge this (no point waiting, we just run GH/OCP CI in #1327)

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to rebase.

@mocenas
Copy link
Contributor Author

mocenas commented Sep 17, 2024

Please don't forget to rebase.

Rebased.

IDK do we need to run CI again?

@michalvavrik
Copy link
Member

IDK do we need to run CI again?

NO!

@michalvavrik michalvavrik merged commit fd1d878 into 1.5.z Sep 17, 2024
2 of 6 checks passed
@michalvavrik michalvavrik deleted the 1.5.3_release branch September 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants