Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do updates, related to RHBQ 3.15.1 release #1403

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Nov 11, 2024

Summary

  • Remove daily runs
  • Use Quarkus 3.15.1 for PRs
  • Use fixed versions of external applications

Based on https://github.com/quarkus-qe/quarkus-test-framework/blob/main/CONTRIBUTING.md#branches

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

michalvavrik commented Nov 11, 2024

It's nice that you have it documented in https://github.com/quarkus-qe/quarkus-test-framework/blob/main/CONTRIBUTING.md#branches, but I don't like chagnes here, I'd prefer to use 3.15.999-SNAPSHOT. It was @rsvoboda who wrote that section 8190611 so I'll let me to review & approve & merge.

@michalvavrik michalvavrik requested review from rsvoboda and removed request for michalvavrik November 11, 2024 17:30
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR.yaml - use 3.15.999-SNAPSHOT

@rsvoboda
Copy link
Member

Also split into 2 commits would be better - one for GH action changes and one for code changes

@fedinskiy fedinskiy force-pushed the update/release-3.15.1 branch 2 times, most recently from 7bc8dc4 to 0baee27 Compare November 12, 2024 16:04
Part of 3.15.1 post-release tasks
@fedinskiy fedinskiy force-pushed the update/release-3.15.1 branch 3 times, most recently from 60740e2 to f1e388a Compare November 12, 2024 16:44
- Drop daily runs
- Use 3.15.999-SNAPSHOT and 3.15.1 for RP runs
- Hardcode ide-config (it has a separate release process)
@rsvoboda rsvoboda merged commit 1bd1aaa into quarkus-qe:1.5.z Nov 12, 2024
8 checks passed
@fedinskiy fedinskiy deleted the update/release-3.15.1 branch November 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants