Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry container launch if failed #1407

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 20, 2024

Summary

Test containers sometimes fails to launch (especially on podman), we can try to relaunch them in case of a failure.

Edit:
I changed the startup limit count to be configurable. By default it is 1 (will not retry at all), but can be configured using maven CLI -Dts.global.container-startup-attempts=2. So we can use it only it jobs where we want to retry.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas marked this pull request as draft November 20, 2024 12:32
@mocenas mocenas force-pushed the retry_service_start branch 2 times, most recently from 65a3374 to 7f70e70 Compare November 20, 2024 13:29
@mocenas mocenas marked this pull request as ready for review November 20, 2024 13:30
@mocenas mocenas changed the title DRAFT: Retry container launch if failed Retry container launch if failed Nov 20, 2024
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good and thanks very much for looking into it, but please address my comment.

@mocenas mocenas merged commit b8a77e1 into quarkus-qe:main Nov 20, 2024
7 checks passed
@mocenas mocenas deleted the retry_service_start branch November 20, 2024 15:09
@mocenas mocenas added triage/backport-1.4? Quarkus 3.8 stream triage/backport-1.5? Quarkus 3.15 stream labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/backport-1.4? Quarkus 3.8 stream triage/backport-1.5? Quarkus 3.15 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants