Do not use deprecated classes and methods #1411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
According to https://github.com/testcontainers/testcontainers-java/pull/9139/files this should work with confluentinc/cp-kafka images version 7.4.0 and later and we are on the 7.6.1 version. So LGTM if CI agrees.
fedinskiy
force-pushed
the
fix/deprecated
branch
from
3ec861a
to
e37aa87
Compare
fedinskiy
changed the title
|
Looks like you will need a rebase. |
fedinskiy
force-pushed
the
fix/deprecated
branch
2 times, most recently
from
ee82153
to
1c83be1
Compare
michalvavrik
dismissed
their stale review
changes will require new review, but I shall wait for green CI
fedinskiy
force-pushed
the
fix/deprecated
branch
from
1c83be1
to
2ee253d
Compare
|
run tests |
See quarkusio/quarkus#44612 for details Previous version was removed here due to deprecation: quarkus-qe/quarkus-test-framework@77ee8d5#diff-297033851be162e9f425d8b2dfdc83df0fa54100ca3714478d9a67c8690c7fbdL24
fedinskiy
force-pushed
the
fix/deprecated
branch
from
2ee253d
to
72de9db
Compare
|
run tests |
|
After an update to the class for running Kafka, testcontainers are not able to connect to cp-schema-registry container. This library is really a gift, that keeps on giving. @michalvavrik I would not be able to work on this PR during the next week, so feel free to close it and the related task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes a single deprecated class and updates usage of deprecated functionality, which was completely removed earlier
Please check the relevant options
run testsphrase in comment)Checklist: