[3.15] Disable tests that have no IBM ppc64le or s390x supporting images

[redmark-redhat]

Summary

Disable tests that have no IBM ppc64le or s390x supporting images. Also, reference images, in the POM file, that do support ppc64le or s390x.

Please select the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• Dependency update
• Refactoring
• Backport
• New scenario (non-breaking change which adds functionality)
• This change requires a documentation update
• This change requires execution against OCP (use run tests phrase in comment)

Checklist:

• Methods and classes used in PR scenarios are meaningful
• Commits are well encapsulated and follow the best practices

[fedinskiy]

@redmark-redhat there are some conflicts

[redmark-redhat]

@fedinskiy conflicts are resolved.

[michalvavrik]

@fedinskiy conflicts are resolved.

no, they are not

[michalvavrik]

@mjurc @fedinskiy please don't merged this PR until questions are answered here #2123 (review)

[michalvavrik]

redmark-redhat requested a review from michalvavrik 30 minutes ago

@redmark-redhat not sure why are you requesting my review? You are disabling classes you don't need to, we discussed it in several channels by now (Slack, other PRs), you don't run baremetal tests, so why are you disabling them?

Dismissing review since Michal Vavrik is correct

[redmark-redhat]

@michalvavrik I guess I'm unclear which are baremetal tests and which are openshift tests. I see some tests are @OpenShiftScenario which I believe is openshift. How are baremetal ones tagged?

To disable ones like MSSQL I followed the aarch64 way. Any tests that had @DisabledIfSystemProperty(named = "ts.arm.missing.services.excludes", matches = "true", disabledReason = "https://github.com/quarkus-qe/quarkus-test-suite/issues/2017") I removed it for ppc64le and s390x.

e.g.
@DisabledIfSystemProperty(named = "ts.arm.missing.services.excludes", matches = "true", disabledReason = "#2017")
@DisabledIfSystemProperty(named = "ts.ibm-z-p.missing.services.excludes", matches = "true", disabledReason = "MSSQL image is not available for IBM s390x and ppc64le")

[michalvavrik]

@redmark-redhat you could see that in Maven POM file, because there are exclusion patterns, but I am happy to translate it for you. Here you go:

• it is an OpenShift test if test class name starts with OpenShift
• it is not an OpenShift test if test class name does not start with OpenShift

[fedinskiy]

@redmark-redhat any test which is not tagged with Openshift (and is not called OpenShift${something}IT) is a baremetal one.
Baremetal tests are run on the same machine where you start the execution. Openshift tests are run on the cluster, to which you're currently connected (via oc cli). When you run openshift tests, the baremetal ones are disabled automatically (see profiles in pom.xml).
As far as we know, you do not start you execution on IBM machines, so it makes no sense for you to run baremetal tests and thus no need to disable any of them via annotations.
Please disable Openshift tests you have problems with, remove any changes to baremetal tests and check youe Jenkins config, so you wouldn't run any baremetal tests accidentally.

[redmark-redhat]

Thanks, I'll backout the baremetal changes ASAP.

[michalvavrik]

LGTM

[michalvavrik]

@redmark-redhat 5 commits is bit excessive for such a PR, could you please squash it?

[redmark-redhat]

Sure, I have a meeting now but will do it ASAP.

[fedinskiy]

And please resolve conflicts, since they are stopping the merge, @redmark-redhat

[redmark-redhat]

I'll close the PR and rework fresh and clean on Monday.