Merge pull request #559 from edeandrea/remove-observability-from-conf…

…igurator
quarkusio · Jul 17, 2024 · d3ef73c · d3ef73c
2 parents aec69ba + 3503f00
commit d3ef73c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/quarkus-workshop-super-heroes/docs/src/docs/asciidoc/default-options.adoc b/quarkus-workshop-super-heroes/docs/src/docs/asciidoc/default-options.adoc
@@ -1,3 +1,5 @@
+// Make sure the defaults here are kept in sync with
+// both generate-attribute-combinations.sh and index.html!
 :os: all
 :use-ai:
 :use-azure:
@@ -8,4 +10,3 @@
 :use-kubernetes:
 :use-messaging:
 :use-native:
-:use-observability:
diff --git a/quarkus-workshop-super-heroes/docs/src/docs/asciidoc/index.html b/quarkus-workshop-super-heroes/docs/src/docs/asciidoc/index.html
@@ -87,6 +87,8 @@ <h4 class="no-underline"><i class="fas fa-desktop"></i>What operating system are
         <h4 class="no-underline" id="feature-selector"><i class="fas fa-book"></i>What content would you like to
             include?
         </h4>
+        <!--  NOTE TO ANYONE WHO MAY COME HERE IN THE FUTURE TO CREATE A NEW SECTION -->
+        <!--  Make sure any changes you make here also have corresponding changes in generate-attribute-combinations.sh and default-options.adoc!      -->
         <ul class="configurator">
             <li id="use-ai-li">
                 <label>
@@ -129,12 +131,11 @@ <h4 class="no-underline" id="feature-selector"><i class="fas fa-book"></i>What c
                     <input type="checkbox" id="use-native">Native compilation
                 </label>
             </li>
-            <li>
-            <li id="use-observability-li">
-                <label>
-                    <input type="checkbox" id="use-observability">Observability
-                </label>
-            </li>
+<!--            <li id="use-observability-li">-->
+<!--                <label>-->
+<!--                    <input type="checkbox" id="use-observability">Observability-->
+<!--                </label>-->
+<!--            </li>-->
         </ul>
         <button class="big" onclick="generateTailoredURL()">
             Take me to my custom workshop

diff --git a/...kus-workshop-super-heroes/docs/src/resource-generation/generate-attribute-combinations.sh b/...kus-workshop-super-heroes/docs/src/resource-generation/generate-attribute-combinations.sh
@@ -3,6 +3,8 @@ set -e
 
 # Define the variable variations
 # To disable a variant, just set it to false, rather than removing it (or remove it everywhere, including the pom and the HTML)
+# NOTE: If you disable it here, you also need to remove it from the configurator: index.html
+# and also from default-options.adoc
 ai=("true" "false")
 azure=("true" "false")
 cli=("false")