Move narayana-lra extension to the new separated LRA project #44513
+15
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview a3ce841 has been successfully built and deployed to https://quarkus-pr-main-44513-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
|
@radcortez I think we have a problem with the new config stuff. We have another failure here with: |
|
I was looking into it, but I really can't explain the cause yet. To make things worse, it is an intermittent error :( |
gsmet
requested changes
Nov 15, 2024
bom/application/pom.xml
Outdated
| @@ -97,6 +97,7 @@ | |||
| <!-- See root POM for hibernate-orm.version, hibernate-reactive.version, hibernate-validator.version, | |||
| hibernate-search.version, antlr.version, bytebuddy.version, hibernate-commons-annotations.version --> | |||
| <narayana.version>7.1.0.Final</narayana.version> | |||
| <narayana.version.lra>0.0.9.Final</narayana.version.lra> | |||
There was a problem hiding this comment.
Let's use narayana-lra.version instead please.
bom/application/pom.xml
Outdated
Comment on lines
4773
to
4776
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>narayana-lra</artifactId> | ||
| </exclusion> |
There was a problem hiding this comment.
Not related to your patch but while we're at it: I think this exclusion can go away. Probably some remnants from when we had the Jakarta artifacts.
bom/application/pom.xml
Outdated
Comment on lines
4796
to
4799
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-service-base</artifactId> | ||
| </exclusion> |
bom/application/pom.xml
Outdated
Comment on lines
4816
to
4819
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-proxy-api</artifactId> | ||
| </exclusion> |
bom/application/pom.xml
Outdated
Comment on lines
4827
to
4830
| <exclusion> | ||
| <groupId>org.jboss.narayana.rts</groupId> | ||
| <groupId>org.jboss.narayana.lra</groupId> | ||
| <artifactId>lra-client</artifactId> | ||
| </exclusion> |
This was referenced Nov 15, 2024
xstefank
force-pushed
the
lra-separation
branch
from
d3cc7ea
to
9c9e1dc
Compare
|
@gsmet sorry for the late update, busy with the book. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gsmet
force-pushed
the
lra-separation
branch
from
9c9e1dc
to
e74d9c7
Compare
gsmet
approved these changes
Nov 25, 2024
gsmet
added
the
triage/waiting-for-ci
Status for workflow
|
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narayana LRA moved to a separate repository with a separate lifecycle - https://github.com/jbosstm/lra.