-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register default configuration smallrye configuration files as resources #44652
base: main
Are you sure you want to change the base?
Register default configuration smallrye configuration files as resources #44652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we already generate a class with the configuration from all the resources found in the classpath, so we don't need to include additional resources or even load them.
I've been wanting to disable this for a while, but I have yet to determine the implications in JVM mode, so I guess the right fix for now it is to disable it for native image only.
That's right and we have discussed this in the past.
IIRC last time we discussed about it, it was not clear how to achieve this. Did anything change since then? |
What exactly would be different in JVM mode? |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Native Tests - Misc3 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - Misc3 #
- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config
✖ io.quarkus.it.smallrye.config.SmallRyeConfigIT.mpConfigProperties
- History - More details - Source on GitHub
java.lang.AssertionError:
1 expectation failed.
JSON path value doesn't match.
Expected: 9090
Actual: 8080
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/panache/hibernate-reactive-rest-data-panache/deployment
✖ io.quarkus.hibernate.reactive.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateComplexObject
- History
1 expectation failed. JSON path name doesn't match. Expected: is "updated collection" Actual: empty collection
-java.lang.AssertionError
java.lang.AssertionError:
1 expectation failed.
JSON path name doesn't match.
Expected: is "updated collection"
Actual: empty collection
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
⚙️ JVM Tests - JDK 21
📦 extensions/micrometer/deployment
✖ io.quarkus.micrometer.deployment.binder.VertxHttpClientMetricsTest.testWebClientMetrics
- History
event executor terminated
-java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)
Relates to #41995