Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit security-cors.adoc #44755

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 26, 2024

Improve style and clarity.

@rolfedh rolfedh changed the title Copyedit security-cors.adoc [WIP] Copyedit security-cors.adoc Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

🎊 PR Preview a36e483 has been successfully built and deployed to https://quarkus-pr-main-44755-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

Copy link
Contributor Author

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sberyozkin. Please let me know if we can make further improvements!

docs/src/main/asciidoc/security-cors.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-cors.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-cors.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-cors.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-cors.adoc Outdated Show resolved Hide resolved
@rolfedh rolfedh changed the title [WIP] Copyedit security-cors.adoc Copyedit security-cors.adoc Nov 27, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 27, 2024

Didn't we already discuss the fact that we wanted to avoid large backports to 3.15 after the first release, included in doc?

Is there any particular reason why this PR has the backport-3.15 label?

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 27, 2024

Hi @gsmet,
cc: @max, @sberyozkin, @sangeetaraghu
[revised message]

Thank you for pointing this out. I realize now the backport/3.15 label doesn’t apply, and I’ve removed it—apologies for any disruption this caused.

I added it because I’m working to downstream security docs for Keycloak, JWT, and CORS (about five files) into 3.15.x product documentation but misunderstood the guidelines around large backports.

Would it be possible for me to cherry-pick these PRs into the 3.15 branch manually? If not, I’ll coordinate with Sangeeta next week to explore other options.

Best regards,
Rolfe

Copy link

quarkus-bot bot commented Nov 27, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit bae368c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants