Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit security-cors.adoc #44755

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 26, 2024

Improve style and clarity.

@rolfedh rolfedh requested a review from sberyozkin November 26, 2024 21:54
@rolfedh rolfedh changed the title Copyedit security-cors.adoc [WIP] Copyedit security-cors.adoc Nov 26, 2024
@rolfedh rolfedh force-pushed the copyedit-cors-ref-topic branch from 2856241 to afb52c1 Compare November 26, 2024 21:57
Copy link

github-actions bot commented Nov 26, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@rolfedh rolfedh force-pushed the copyedit-cors-ref-topic branch from afb52c1 to b06227e Compare November 27, 2024 15:34
Copy link
Contributor Author

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sberyozkin. Please let me know if we can make further improvements!

@rolfedh rolfedh force-pushed the copyedit-cors-ref-topic branch 2 times, most recently from 3eb86b1 to 43e9552 Compare November 27, 2024 15:51
@rolfedh rolfedh changed the title [WIP] Copyedit security-cors.adoc Copyedit security-cors.adoc Nov 27, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 27, 2024

Didn't we already discuss the fact that we wanted to avoid large backports to 3.15 after the first release, included in doc?

Is there any particular reason why this PR has the backport-3.15 label?

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 27, 2024

Hi @gsmet,
cc: @max, @sberyozkin, @sangeetaraghu
[revised message]

Thank you for pointing this out. I realize now the backport/3.15 label doesn’t apply, and I’ve removed it—apologies for any disruption this caused.

I added it because I’m working to downstream security docs for Keycloak, JWT, and CORS (about five files) into 3.15.x product documentation but misunderstood the guidelines around large backports.

Would it be possible for me to cherry-pick these PRs into the 3.15 branch manually? If not, I’ll coordinate with Sangeeta next week to explore other options.

Best regards,
Rolfe

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolfedh for improving the doc

@sberyozkin
Copy link
Member

@rolfedh Hi Rolfe, PR has a merge commit: [sha=bae368c86a0cfa7b361e36557d05415b5fe4f511 ; message="Merge branch 'main' into copyedit-cors-ref-topic"]

@rolfedh rolfedh force-pushed the copyedit-cors-ref-topic branch from bae368c to 6d99105 Compare November 28, 2024 17:59
Copy link

quarkus-bot bot commented Nov 28, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 6d99105.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

Thanks @rolfedh

@sberyozkin sberyozkin merged commit 1f6a3a9 into quarkusio:main Nov 29, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 29, 2024
@sberyozkin sberyozkin deleted the copyedit-cors-ref-topic branch November 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants