Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ci for both core and sdk #6

Merged
merged 5 commits into from
Mar 12, 2024
Merged

chore: add ci for both core and sdk #6

merged 5 commits into from
Mar 12, 2024

Conversation

0xtekgrinder
Copy link
Collaborator

Description

Please provide a detailed description of what was done in this PR.

Changes include

  • Bugfix (non-breaking change that solves an issue).
  • Hotfix (change that solves an urgent issue, and requires immediate attention).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (change that is not backwards-compatible and/or changes current functionality).
  • Documentation update (change added to any kind of documentation).

Checklist

  • I have assigned this PR to myself.
  • I have added at least 1 reviewer.
  • I have added the relevant labels.
  • I have updated the official documentation.
  • I have added sufficient documentation in code.

Testing

  • I have tested this code with the official test suite.
  • I have tested this code manually.

@0xtekgrinder 0xtekgrinder added the ci Feature or fix with an impact on the Continuous Integration label Mar 12, 2024
@0xtekgrinder 0xtekgrinder self-assigned this Mar 12, 2024
0xpanoramix
0xpanoramix requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@0xpanoramix 0xpanoramix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made one small reco, otherwise LGTM!

.github/workflows/scanner-core-ci.yml Outdated Show resolved Hide resolved
@0xtekgrinder 0xtekgrinder merged commit e5e1b4e into main Mar 12, 2024
10 checks passed
@0xtekgrinder 0xtekgrinder deleted the chore/ci branch March 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xpanoramix 0xpanoramix 0xpanoramix requested changes

Assignees

@0xtekgrinder 0xtekgrinder

Labels
ci Feature or fix with an impact on the Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xtekgrinder @0xpanoramix