validation: ignore err in LoadCerts

[crozzy]

It's possible users may keep other .key files in this dir
(e.g. cosigning files) if they aren't readable, this causes an
error despite there also being ssl.cert and ssl.key files
available.

Signed-off-by: crozzy [email protected]

Issue: None

Changelog:

Docs:

Testing:

bash-4.4$ ls -l /conf/stack
total 28
-rwxrwxr-x. 1 118686 118686 2753 Jan  1  1970 config.yaml
-rw-------. 1 118686 118686  649 Sep  2 13:33 cosign.key
-rw-------. 1 118686 118686  178 Sep  2 13:33 cosign.pub
drwxrwxr-x. 2 118686 118686    6 Jan  1  1970 extra_ca_certs
-rwxrwxr-x. 1 118686 118686 1338 Jan  1  1970 ssl.cert
-rwxrwxr-x. 1 118686 118686 1675 Jan  1  1970 ssl.key

sudo podman run -it --rm -p 80:8080 -p 443:8443     --name=quay    -v $QUAY/config:/conf/stack:Z    -v $QUAY/storage:/datastorage:Z  QUAY_IMAGE

Certificate ssl.cert is required for HostSettings .

Details:

---

(This section may be deleted.)
All fields are required. If a field is not applicable (eg. no relevant CHANGELOG.md), specify "none" or "n/a".

Issue: This is the PROJQUAY jira reference. Pull-request title must start with issue name "PROJQUAY-1234 - ".

Changelog: One line description to be added to CHANGELOG.md during release builds. Typically starts with "Added:", "Fixed:", "Note:", etc.

Docs: Detailed description of changes necessary to docs.projectquay.io. Examples would be addition of config.yaml, indication of UI changes and screenshot impact, and changes in behavior of features.

Testing: Detailed description of how to test changes manually. This section combined with the Docs section above must be sufficiently clear for full test cases to be performed.

Details: Other information meant for pull-request reviewers and developers.

[crozzy]

@jonathankingfc I think either this returning an error here https://github.com/quay/config-tool/blob/master/commands/validate.go#L74 (there is already an error check so assume that already existed at some point).

Let me know what you think.

[crozzy]

I'm going to close this as it's pretty stale, I still think we should revisit this on a larger level, ie. not expecting a clean environment; just going after what we need.

[jonathankingfc]

Re-opening this pull request as it has shown up again in OMR

[flavianmissi]

are the test failures related to the changes? 🤔