Prevent anonymous volume creation (PROJQUAY-6053) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammerMeetNail
changed the title
|
thanks for this, it was driving me nuts! 🤣 |
HammerMeetNail
force-pushed
the
ignore_existing_image_volumes
branch
from
0ec904f to
b79f44e
Compare
HammerMeetNail
added
ok-to-test
harishsurf
requested changes
Dec 7, 2023
There was a problem hiding this comment.
@robbmanes thank sm for this! Could you also add the flag for the redis.service.j2? I am seeing one anon. volume created by redis on every pod restart on my machine:
$ podman volume ls
DRIVER VOLUME NAME
local 1f63663da44c2dbc5561971877437ca2d9bdd48015fdb275eede096046123481
local c317d65382a3df07e290cced33854642fe8f66f24b3ee0f801a6e62873830545
local pg-storage
local quay-storage
|
Thanks for the work on this, can we finish it up and get it merged? IHAC who frequently complain about this |
|
@robbmanes Could take another look when you have a moment? |
When performing a mirror-registry installation or restarting the "quay-pod" service, baked-in volumes to the image for "/tmp" and "/var/log" get created every time the "quay-app" container is made within the pod. By using "--image-volume=ignore", any specifically defined Dockerfile VOLUME directives do not have volumes made for them, preventing anonymous volumes from being made by the "podman run" command. Signed-off-by: Robb Manes <[email protected]>
robbmanes
force-pushed
the
ignore_existing_image_volumes
branch
from
b79f44e to
a8c19b6
Compare
|
Sorry all; I got super sick for a long time. Am doing better now, PR squashed/updated to include redis template, tested WFM. |
robbmanes
commented
Jan 29, 2024
harishsurf
added
ok-to-test
HammerMeetNail
added
ok-to-test
harishsurf
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a mirror-registry installation or restarting the "quay-pod" service, baked-in volumes to the image for
/tmpand/var/logget created every time thequay-appcontainer is made within the pod. By using--image-volume=ignore, any specifically defined DockerfileVOLUMEdirectives do not have volumes made for them, preventing anonymous volumes from being made by thepodman runcommand.Prior to adding this, anonymous volumes would pile up like so for these paths:
Now just the explicitly named volumes are made from the service units and no anonymous volumes are being made: