Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Quay Storage Directory #175

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

sveno1990
Copy link
Contributor

@sveno1990 sveno1990 commented Oct 23, 2024

Currently if you run the installer with a user that does not have UID = 1000 and has a umask that is not 002 (e.g. 027) and quayStorage pointing to a (not yet) existing dir. The container wil not have permissions to write files in the directory. The commit should fix this.

The describe situation results in bad gateway 502 errors in when pushing to the registry. In the quay-app this results in various permission denied errors in the logs.

@harishsurf harishsurf added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 23, 2024
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you for your contribution!

@harishsurf harishsurf merged commit fc7f7f5 into quay:main Oct 24, 2024
8 checks passed
@bcaton85
Copy link
Contributor

/cherry-pick mirror-registry-2.0-rhel-8

@openshift-cherrypick-robot

@bcaton85: new pull request could not be created: failed to create pull request against quay/mirror-registry#mirror-registry-2.0-rhel-8 from head openshift-cherrypick-robot:cherry-pick-175-to-mirror-registry-2.0-rhel-8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between quay:mirror-registry-2.0-rhel-8 and openshift-cherrypick-robot:cherry-pick-175-to-mirror-registry-2.0-rhel-8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick mirror-registry-2.0-rhel-8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Development

Successfully merging this pull request may close these issues.

4 participants