Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test/mock quay client (PROJQUAY-6620) #115

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

arborite-rh
Copy link
Contributor

@arborite-rh arborite-rh commented Mar 4, 2024

Adds test coverage for the quay client by implementing a mock http
client interface and mocking json body responses.

Topic: client-unit-test

Relative: 1.20
Signed-off-by: Ross Bryan [email protected]

@arborite-rh
Copy link
Contributor Author

arborite-rh commented Mar 4, 2024

Reviews in this chain:
#115 test: unit test/mock quay client (PROJQUAY-6620)

@arborite-rh
Copy link
Contributor Author

arborite-rh commented Mar 4, 2024

# head base diff date summary
0 b35742ee b3425310 diff Mar 4 7:03 AM 31 files changed, 8685 insertions(+), 44 deletions(-)
1 552f9b83 b3425310 diff Mar 4 8:32 AM 1 file changed, 4 insertions(+)
2 aac7d61b b3425310 diff Mar 4 8:32 AM 1 file changed, 1 insertion(+), 1 deletion(-)
3 bb969194 d6fc9522 rebase Mar 6 13:19 PM 0 files changed
4 cdf906df 0b59794f diff Mar 6 13:23 PM 0 files changed
5 57f2a6ef 7a89bdfb rebase Mar 6 13:24 PM 0 files changed
6 070f4075 557a20a5 rebase Mar 7 17:07 PM 0 files changed
7 1e4ee311 dd328b2b rebase Mar 8 7:47 AM 0 files changed
8 9fb4f254 223b31ab rebase Mar 12 10:47 AM 0 files changed

@openshift-ci openshift-ci bot requested review from dmage and flavianmissi March 4, 2024 12:04
@arborite-rh arborite-rh force-pushed the rb/revup/master/client-unit-test branch 2 times, most recently from 552f9b8 to aac7d61 Compare March 4, 2024 13:32
@arborite-rh arborite-rh force-pushed the rb/revup/master/quay-lint branch from b342531 to d6fc952 Compare March 6, 2024 18:19
@arborite-rh arborite-rh force-pushed the rb/revup/master/client-unit-test branch 2 times, most recently from bb96919 to cdf906d Compare March 6, 2024 18:23
@arborite-rh arborite-rh force-pushed the rb/revup/master/quay-lint branch from d6fc952 to 94b7c82 Compare March 6, 2024 18:23
@arborite-rh arborite-rh changed the title test: unit test/mock quay client test: unit test/mock quay client (PROJQUAY-6620) Mar 6, 2024
@arborite-rh arborite-rh changed the base branch from rb/revup/master/quay-lint to rb/revup/master/1.20 March 6, 2024 18:23
@arborite-rh arborite-rh force-pushed the rb/revup/master/1.20 branch from 0b59794 to 7a89bdf Compare March 6, 2024 18:24
@arborite-rh arborite-rh force-pushed the rb/revup/master/client-unit-test branch 2 times, most recently from 57f2a6e to 070f407 Compare March 7, 2024 22:07
@arborite-rh arborite-rh force-pushed the rb/revup/master/1.20 branch from 7a89bdf to 557a20a Compare March 7, 2024 22:07
@arborite-rh arborite-rh force-pushed the rb/revup/master/client-unit-test branch from 070f407 to 1e4ee31 Compare March 8, 2024 12:48
@arborite-rh arborite-rh force-pushed the rb/revup/master/1.20 branch from 557a20a to dd328b2 Compare March 8, 2024 12:48
@openshift-ci openshift-ci bot added the approved label Mar 8, 2024
Adds test coverage for the quay client by implementing a mock http
client interface and mocking json body responses.

Topic: client-unit-test

Relative: 1.20
Signed-off-by: Ross Bryan <[email protected]>
@arborite-rh arborite-rh changed the base branch from rb/revup/master/1.20 to master March 12, 2024 14:47
@arborite-rh arborite-rh force-pushed the rb/revup/master/client-unit-test branch from 1e4ee31 to 9fb4f25 Compare March 12, 2024 14:47
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arborite-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a5c6b15 into master Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant