Skip to content

Commit

Permalink
Fix race condition triggered by F2 key
Browse files Browse the repository at this point in the history
  • Loading branch information
philippwerner committed Apr 18, 2024
1 parent ee89f8d commit 7f15bd8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/assets.h
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ static bool transferShareOwnershipAndPossession(int sourceOwnershipIndex, int so
}
}

// Should only be called from tick processor to avoid concurrent asset state changes, which may cause race conditions
static void getUniverseDigest(m256i& digest)
{
unsigned int digestIndex;
Expand Down
11 changes: 4 additions & 7 deletions src/qubic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ static void enableAVX()
));
}

// Should only be called from tick processor to avoid concurrent state changes, which can cause race conditions as detailed in FIXME below.
static void getComputerDigest(m256i& digest)
{
unsigned int digestIndex;
Expand Down Expand Up @@ -4560,7 +4561,7 @@ static void processKeyPresses()

CHAR16 digestChars[60 + 1];

getIdentity((unsigned char*)&spectrumDigests[(SPECTRUM_CAPACITY * 2 - 1) - 1], digestChars, true);
getIdentity(etalonTick.saltedSpectrumDigest.m256i_u8, digestChars, true);
unsigned int numberOfEntities = 0;
unsigned long long totalAmount = 0;
for (unsigned int i = 0; i < SPECTRUM_CAPACITY; i++)
Expand All @@ -4581,18 +4582,14 @@ static void processKeyPresses()
appendText(message, L" transactions.");
logToConsole(message);

m256i digest;

setText(message, L"Universe digest = ");
getUniverseDigest(digest);
getIdentity((unsigned char*)&digest, digestChars, true);
getIdentity(etalonTick.saltedUniverseDigest.m256i_u8, digestChars, true);
appendText(message, digestChars);
appendText(message, L".");
logToConsole(message);

setText(message, L"Computer digest = ");
getComputerDigest(digest);
getIdentity((unsigned char*)&digest, digestChars, true);
getIdentity(etalonTick.saltedComputerDigest.m256i_u8, digestChars, true);
appendText(message, digestChars);
appendText(message, L".");
logToConsole(message);
Expand Down

0 comments on commit 7f15bd8

Please sign in to comment.