Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Testcases when Logging is enabled #244

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Failing Testcases when Logging is enabled #244

merged 3 commits into from
Dec 20, 2024

Conversation

Franziska-Mueller
Copy link
Collaborator

closes #236

@Franziska-Mueller Franziska-Mueller linked an issue Dec 19, 2024 that may be closed by this pull request
Failing Testcases when Logging is enabled #236
Closed
@Franziska-Mueller Franziska-Mueller changed the base branch from main to develop December 19, 2024 15:57
@Franziska-Mueller Franziska-Mueller marked this pull request as ready for review December 20, 2024 10:28
fnordspace
fnordspace approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@fnordspace fnordspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Franziska-Mueller Franziska-Mueller merged commit fe1d957 into develop Dec 20, 2024
1 check passed
@Franziska-Mueller Franziska-Mueller deleted the bugfix/2024-12-19-logging-in-tests branch January 7, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnordspace fnordspace fnordspace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing Testcases when Logging is enabled
2 participants
@Franziska-Mueller @fnordspace