feat: added new functions to get the Stats of QVAULT SC #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Franziska-Mueller
requested changes
Jan 3, 2025
src/contracts/QVAULT.h
Outdated
| struct getNumberOfAsset_input | ||
| { | ||
| uint64 assetName; | ||
| id issuer; |
There was a problem hiding this comment.
looks like the whitespace is off here
|
|
||
| if(input.epoch < QVAULT_INITIAL_EPOCH || input.epoch >= QVAULT_MAX_EPOCHS) | ||
| { | ||
| return ; |
There was a problem hiding this comment.
make sure that the output contains default values
There was a problem hiding this comment.
default values for output are all 0.
src/contracts/QVAULT.h
Outdated
| locals.statsOfEpoch.revenueOfQcapHolders = locals.paymentForQCAPHolders; | ||
| locals.statsOfEpoch.revenueOfOneQcap = div(locals.paymentForQCAPHolders, locals.circulatedSupply); | ||
| locals.statsOfEpoch.revenueOfQvaultHolders = locals.paymentForShareholders; | ||
| locals.statsOfEpoch.revenueOfOneQvault = div(locals.paymentForShareholders, 676ULL); |
There was a problem hiding this comment.
use your global variable instead of the hard-coded number
removed the whitespace
Franziska-Mueller
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getNumberOfAsset- we can get the number of assets that QVAULT holds using this function.getStatsPerEpoch- we can get the Stats of QVUALT SC in special epoch using this function.These functions are already tested on testnet with qubic-cli and also I have added the gtest.
The IPO of QVAULT is finished and we need to update the size of QVAULT SC to use the below sturct to save the Stats data.
`struct StatsInfo
{
uint64 totalRevenue;
uint64 revenueOfQcapHolders;
uint64 revenueOfOneQcap;
uint64 revenueOfQvaultHolders;
uint64 revenueOfOneQvault;
uint64 revenueOfReinvesting;
uint64 revenueOfDevTeam;
};
array<StatsInfo, QVAULT_MAX_EPOCHS> _allEpochStats;`