Add proper saving for last tick quorum data per epoch interval #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xluk
reviewed
Dec 3, 2024
validator/tick/models.go
Outdated
| return interval, nil | ||
| } | ||
|
|
||
| return nil, errors.New(fmt.Sprintf("unable to find processed tick intervals for epoch %d", epoch)) |
There was a problem hiding this comment.
errors.Errorf should be used instead of errors.New with Sprintf
0xluk
reviewed
Dec 3, 2024
validator/tick/models.go
Outdated
| return nil, errors.New(fmt.Sprintf("unable to find processed tick intervals for epoch %d", epoch)) | ||
| } | ||
|
|
||
| func IsLast(tickNumber uint32, epoch uint32, intervals []*protobuff.ProcessedTickIntervalsPerEpoch) (bool, int, error) { |
There was a problem hiding this comment.
this function is not self explanatory from the definition, you either redefine it or if you can't change it to make it more explanatory, then adding a comment is mandatory
0xluk
reviewed
Dec 3, 2024
store/store.go
Outdated
| for key, qd := range lastQuorumDataPerEpochIntervals.QuorumDataPerInterval { | ||
|
|
||
| if qd != nil { | ||
| fmt.Printf("DEBUG: %d %d\n", key, qd.QuorumTickStructure.TickNumber) |
There was a problem hiding this comment.
do you need to remove the debug print statements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.