added early exit clause in GetTickEvents which return early when no t…

…ransactions are present in the specified tick
qubic · Dec 20, 2024 · 061f9c4 · 061f9c4
1 parent 658c30c
commit 061f9c4
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/sdk/events/client.go b/sdk/events/client.go
@@ -69,6 +69,10 @@ func (c *Client) GetTickEventsOneByOne(ctx context.Context, passcode [4]uint64,
 		return nil, errors.Wrap(err, "getting tick data")
 	}
 
+	if len(td.TransactionIds) == 0 {
+		return &qubicpb.TickEvents{Tick: tickNumber, TxEvents: []*qubicpb.TransactionEvents{}}, nil
+	}
+
 	txEvents := make([]*qubicpb.TransactionEvents, 0, len(td.TransactionIds))
 
 	for txIndex, txID := range td.TransactionIds {
@@ -128,6 +132,10 @@ func (c *Client) GetTickEvents(ctx context.Context, passcode [4]uint64, tickNumb
 		return nil, errors.Wrap(err, "getting tick data")
 	}
 
+	if len(td.TransactionIds) == 0 {
+		return &qubicpb.TickEvents{Tick: tickNumber, TxEvents: []*qubicpb.TransactionEvents{}}, nil
+	}
+
 	req := struct {
 		Passcode   [4]uint64
 		TickNumber uint32
@@ -159,6 +167,10 @@ func (c *Client) GetTickEvents(ctx context.Context, passcode [4]uint64, tickNumb
 		endEventId = result.FromEventID[i] + result.Length[i] - 1
 	}
 
+	if startEventId == math.MaxInt64 {
+		return &qubicpb.TickEvents{Tick: tickNumber, TxEvents: []*qubicpb.TransactionEvents{}}, nil
+	}
+
 	events, err := c.GetRangeEvents(ctx, passcode, uint64(startEventId), uint64(endEventId))
 	if err != nil {
 		return nil, errors.Wrap(err, "getting range events")