-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add upgrade handler for v1.7.5 #1767
Conversation
WalkthroughThe changes in this pull request introduce a new upgrade constant and handler for version Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
app/upgrades/types.go
(1 hunks)app/upgrades/upgrades.go
(1 hunks)app/upgrades/v1_7.go
(1 hunks)app/upgrades_test.go
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- app/upgrades/types.go
🧰 Additional context used
🪛 GitHub Check: devskim
app/upgrades_test.go
[failure] 485-485: A token or key was found in source code. If this represents a secret, it should be moved somewhere else.
Do not store tokens or keys in source code.
🔇 Additional comments (1)
app/upgrades/upgrades.go (1)
30-30
: LGTM: Upgrade entry correctly added
The new upgrade entry for V010705UpgradeName
has been correctly added to the Upgrades
function, ensuring the new handler is included in the upgrade process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 61.41% 61.43% +0.01%
==========================================
Files 196 196
Lines 17105 17117 +12
==========================================
+ Hits 10505 10515 +10
- Misses 5747 5748 +1
- Partials 853 854 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1. Summary
Add upgrade handler and test for v1.7.5.
This upgrade handler resets the redemption rate on Cosmoshub-4, based upon the fixed logic in v1.7.5.
As of 3/12, this would be 1.3875 atom to 1 qatom.
It also sets the last redemption rate to 1.38, which is that rate at which unbondings take place.
Summary by CodeRabbit
New Features
v1.7.5
, to enhance upgrade tracking.v1.7.5
to manage withdrawal records and redemption rates.Bug Fixes
Tests
v1.7.5
upgrade handler.